Commit 8a8d0485 authored by Paul Cercueil's avatar Paul Cercueil Committed by Lee Jones

mfd: max14577: Remove #ifdef guards for PM related functions

Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros
to handle the .suspend/.resume callbacks.

These macros allow the suspend and resume functions to be automatically
dropped by the compiler when CONFIG_SUSPEND is disabled, without having
to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.
Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 50d3ac7d
...@@ -480,7 +480,6 @@ static const struct i2c_device_id max14577_i2c_id[] = { ...@@ -480,7 +480,6 @@ static const struct i2c_device_id max14577_i2c_id[] = {
}; };
MODULE_DEVICE_TABLE(i2c, max14577_i2c_id); MODULE_DEVICE_TABLE(i2c, max14577_i2c_id);
#ifdef CONFIG_PM_SLEEP
static int max14577_suspend(struct device *dev) static int max14577_suspend(struct device *dev)
{ {
struct i2c_client *i2c = to_i2c_client(dev); struct i2c_client *i2c = to_i2c_client(dev);
...@@ -513,14 +512,13 @@ static int max14577_resume(struct device *dev) ...@@ -513,14 +512,13 @@ static int max14577_resume(struct device *dev)
return 0; return 0;
} }
#endif /* CONFIG_PM_SLEEP */
static SIMPLE_DEV_PM_OPS(max14577_pm, max14577_suspend, max14577_resume); static DEFINE_SIMPLE_DEV_PM_OPS(max14577_pm, max14577_suspend, max14577_resume);
static struct i2c_driver max14577_i2c_driver = { static struct i2c_driver max14577_i2c_driver = {
.driver = { .driver = {
.name = "max14577", .name = "max14577",
.pm = &max14577_pm, .pm = pm_sleep_ptr(&max14577_pm),
.of_match_table = max14577_dt_match, .of_match_table = max14577_dt_match,
}, },
.probe_new = max14577_i2c_probe, .probe_new = max14577_i2c_probe,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment