Commit 8a93960a authored by Rob Herring (Arm)'s avatar Rob Herring (Arm) Committed by Michael Ellerman

powerpc: Use of_property_present()

Use of_property_present() to test for property presence rather than
of_get_property(). This is part of a larger effort to remove callers
of of_get_property() and similar functions. of_get_property() leaks
the DT property data pointer which is a problem for dynamically
allocated nodes which may be freed.
Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240731191312.1710417-9-robh@kernel.org
parent de9c2c66
...@@ -860,7 +860,7 @@ static int pnv_eeh_bridge_reset(struct pci_dev *pdev, int option) ...@@ -860,7 +860,7 @@ static int pnv_eeh_bridge_reset(struct pci_dev *pdev, int option)
int64_t rc; int64_t rc;
/* Hot reset to the bus if firmware cannot handle */ /* Hot reset to the bus if firmware cannot handle */
if (!dn || !of_get_property(dn, "ibm,reset-by-firmware", NULL)) if (!dn || !of_property_present(dn, "ibm,reset-by-firmware"))
return __pnv_eeh_bridge_reset(pdev, option); return __pnv_eeh_bridge_reset(pdev, option);
pr_debug("%s: FW reset PCI bus %04x:%02x with option %d\n", pr_debug("%s: FW reset PCI bus %04x:%02x with option %d\n",
......
...@@ -393,7 +393,7 @@ void __init opal_lpc_init(void) ...@@ -393,7 +393,7 @@ void __init opal_lpc_init(void)
for_each_compatible_node(np, NULL, "ibm,power8-lpc") { for_each_compatible_node(np, NULL, "ibm,power8-lpc") {
if (!of_device_is_available(np)) if (!of_device_is_available(np))
continue; continue;
if (!of_get_property(np, "primary", NULL)) if (!of_property_present(np, "primary"))
continue; continue;
opal_lpc_chip_id = of_get_ibm_chip_id(np); opal_lpc_chip_id = of_get_ibm_chip_id(np);
of_node_put(np); of_node_put(np);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment