Commit 8b138da6 authored by Daniel Borkmann's avatar Daniel Borkmann Committed by David S. Miller

bpf_dbg: always close socket in bpf_runnable

We must not leave the socket intact in bpf_runnable(). The socket
is used to test if the filter code is being accepted by the kernel
or not. So right after we do the setsockopt(2), we need to close
it again.
Signed-off-by: default avatarDaniel Borkmann <dborkman@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5c509a2e
...@@ -512,11 +512,11 @@ static bool bpf_runnable(struct sock_filter *f, unsigned int len) ...@@ -512,11 +512,11 @@ static bool bpf_runnable(struct sock_filter *f, unsigned int len)
return false; return false;
} }
ret = setsockopt(sock, SOL_SOCKET, SO_ATTACH_FILTER, &bpf, sizeof(bpf)); ret = setsockopt(sock, SOL_SOCKET, SO_ATTACH_FILTER, &bpf, sizeof(bpf));
close(sock);
if (ret < 0) { if (ret < 0) {
rl_printf("program not allowed to run by kernel!\n"); rl_printf("program not allowed to run by kernel!\n");
return false; return false;
} }
close(sock);
for (i = 0; i < len; i++) { for (i = 0; i < len; i++) {
if (BPF_CLASS(f[i].code) == BPF_LD && if (BPF_CLASS(f[i].code) == BPF_LD &&
f[i].k > SKF_AD_OFF) { f[i].k > SKF_AD_OFF) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment