Commit 8b208399 authored by Pan Bian's avatar Pan Bian Committed by Sebastian Reichel

power: supply: isp1704: Fix unchecked return value of devm_kzalloc

Function devm_kzalloc() will return a NULL pointer. However, in function
isp1704_charger_probe(), the return value of devm_kzalloc() is directly
used without validation. This may result in a bad memory access bug.

Fixes: 34a10961 ("isp1704_charger: Add DT support")
Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Reviewed-by: default avatarPali Rohár <pali.rohar@gmail.com>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
parent 756e142a
...@@ -418,6 +418,10 @@ static int isp1704_charger_probe(struct platform_device *pdev) ...@@ -418,6 +418,10 @@ static int isp1704_charger_probe(struct platform_device *pdev)
pdata = devm_kzalloc(&pdev->dev, pdata = devm_kzalloc(&pdev->dev,
sizeof(struct isp1704_charger_data), GFP_KERNEL); sizeof(struct isp1704_charger_data), GFP_KERNEL);
if (!pdata) {
ret = -ENOMEM;
goto fail0;
}
pdata->enable_gpio = gpio; pdata->enable_gpio = gpio;
dev_info(&pdev->dev, "init gpio %d\n", pdata->enable_gpio); dev_info(&pdev->dev, "init gpio %d\n", pdata->enable_gpio);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment