Commit 8ba42fb7 authored by Peter Meerwald's avatar Peter Meerwald Committed by Jonathan Cameron

iio: Fix endianness issue in ak8975_read_axis()

i2c_smbus_read_word_data() does host endian conversion already,
no need for le16_to_cpu()
Signed-off-by: default avatarPeter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
Cc: Stable@vger.kernel.org
parent 6d4eed9e
...@@ -352,8 +352,6 @@ static int ak8975_read_axis(struct iio_dev *indio_dev, int index, int *val) ...@@ -352,8 +352,6 @@ static int ak8975_read_axis(struct iio_dev *indio_dev, int index, int *val)
{ {
struct ak8975_data *data = iio_priv(indio_dev); struct ak8975_data *data = iio_priv(indio_dev);
struct i2c_client *client = data->client; struct i2c_client *client = data->client;
u16 meas_reg;
s16 raw;
int ret; int ret;
mutex_lock(&data->lock); mutex_lock(&data->lock);
...@@ -401,16 +399,11 @@ static int ak8975_read_axis(struct iio_dev *indio_dev, int index, int *val) ...@@ -401,16 +399,11 @@ static int ak8975_read_axis(struct iio_dev *indio_dev, int index, int *val)
dev_err(&client->dev, "Read axis data fails\n"); dev_err(&client->dev, "Read axis data fails\n");
goto exit; goto exit;
} }
meas_reg = ret;
mutex_unlock(&data->lock); mutex_unlock(&data->lock);
/* Endian conversion of the measured values. */
raw = (s16) (le16_to_cpu(meas_reg));
/* Clamp to valid range. */ /* Clamp to valid range. */
raw = clamp_t(s16, raw, -4096, 4095); *val = clamp_t(s16, ret, -4096, 4095);
*val = raw;
return IIO_VAL_INT; return IIO_VAL_INT;
exit: exit:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment