Commit 8bb5b59d authored by Coiby Xu's avatar Coiby Xu Committed by Greg Kroah-Hartman

staging: greybus: codecs: use SNDRV_PCM_FMTBIT_S16_LE for format bitmask

snd_soc_pcm_stream.formats should use the bitmask SNDRV_PCM_FMTBIT_*
instead of the sequential integers SNDRV_PCM_FORMAT_* as explained by
commit e712bfca
("ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask").

Found by sparse,

$ make C=2 drivers/staging/greybus/
drivers/staging/greybus/audio_codec.c:691:36: warning: incorrect type in initializer (different base types)
drivers/staging/greybus/audio_codec.c:691:36:    expected unsigned long long [usertype] formats
drivers/staging/greybus/audio_codec.c:691:36:    got restricted snd_pcm_format_t [usertype]
drivers/staging/greybus/audio_codec.c:701:36: warning: incorrect type in initializer (different base types)
drivers/staging/greybus/audio_codec.c:701:36:    expected unsigned long long [usertype] formats
drivers/staging/greybus/audio_codec.c:701:36:    got restricted snd_pcm_format_t [usertype]
Reviewed-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarCoiby Xu <coiby.xu@gmail.com>
Link: https://lore.kernel.org/r/20201002233057.74462-2-coiby.xu@gmail.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 50a390ad
...@@ -688,7 +688,7 @@ static struct snd_soc_dai_driver gbaudio_dai[] = { ...@@ -688,7 +688,7 @@ static struct snd_soc_dai_driver gbaudio_dai[] = {
.playback = { .playback = {
.stream_name = "I2S 0 Playback", .stream_name = "I2S 0 Playback",
.rates = SNDRV_PCM_RATE_48000, .rates = SNDRV_PCM_RATE_48000,
.formats = SNDRV_PCM_FORMAT_S16_LE, .formats = SNDRV_PCM_FMTBIT_S16_LE,
.rate_max = 48000, .rate_max = 48000,
.rate_min = 48000, .rate_min = 48000,
.channels_min = 1, .channels_min = 1,
...@@ -698,7 +698,7 @@ static struct snd_soc_dai_driver gbaudio_dai[] = { ...@@ -698,7 +698,7 @@ static struct snd_soc_dai_driver gbaudio_dai[] = {
.capture = { .capture = {
.stream_name = "I2S 0 Capture", .stream_name = "I2S 0 Capture",
.rates = SNDRV_PCM_RATE_48000, .rates = SNDRV_PCM_RATE_48000,
.formats = SNDRV_PCM_FORMAT_S16_LE, .formats = SNDRV_PCM_FMTBIT_S16_LE,
.rate_max = 48000, .rate_max = 48000,
.rate_min = 48000, .rate_min = 48000,
.channels_min = 1, .channels_min = 1,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment