Commit 8bc2b3dc authored by Andrew Halaney's avatar Andrew Halaney Committed by Linus Torvalds

init: make unknown command line param message clearer

The prior message is confusing users, which is the exact opposite of the
goal.  If the message is being seen, one of the following situations is
happening:

 1. the param is misspelled
 2. the param is not valid due to the kernel configuration
 3. the param is intended for init but isn't after the '--'
    delineator on the command line

To make that more clear to the user, explicitly mention "kernel command
line" and also note that the params are still passed to user space to
avoid causing any alarm over params intended for init.

Link: https://lkml.kernel.org/r/20211013223502.96756-1-ahalaney@redhat.com
Fixes: 86d1919a ("init: print out unknown kernel parameters")
Signed-off-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Suggested-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Cc: Borislav Petkov <bp@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0858d7da
...@@ -924,7 +924,9 @@ static void __init print_unknown_bootoptions(void) ...@@ -924,7 +924,9 @@ static void __init print_unknown_bootoptions(void)
for (p = &envp_init[2]; *p; p++) for (p = &envp_init[2]; *p; p++)
end += sprintf(end, " %s", *p); end += sprintf(end, " %s", *p);
pr_notice("Unknown command line parameters:%s\n", unknown_options); /* Start at unknown_options[1] to skip the initial space */
pr_notice("Unknown kernel command line parameters \"%s\", will be passed to user space.\n",
&unknown_options[1]);
memblock_free(unknown_options, len); memblock_free(unknown_options, len);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment