Commit 8c3fffe3 authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Herbert Xu

crypto: scompress - initialize per-CPU variables on each CPU

In commit 71052dcf ("crypto: scompress - Use per-CPU struct instead
multiple variables") I accidentally initialized multiple times the memory on a
random CPU. I should have initialize the memory on every CPU like it has
been done earlier. I didn't notice this because the scheduler didn't
move the task to another CPU.
Guenter managed to do that and the code crashed as expected.

Allocate / free per-CPU memory on each CPU.

Fixes: 71052dcf ("crypto: scompress - Use per-CPU struct instead multiple variables")
Reported-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent f0cfd57b
...@@ -76,7 +76,7 @@ static void crypto_scomp_free_scratches(void) ...@@ -76,7 +76,7 @@ static void crypto_scomp_free_scratches(void)
int i; int i;
for_each_possible_cpu(i) { for_each_possible_cpu(i) {
scratch = raw_cpu_ptr(&scomp_scratch); scratch = per_cpu_ptr(&scomp_scratch, i);
vfree(scratch->src); vfree(scratch->src);
vfree(scratch->dst); vfree(scratch->dst);
...@@ -93,7 +93,7 @@ static int crypto_scomp_alloc_scratches(void) ...@@ -93,7 +93,7 @@ static int crypto_scomp_alloc_scratches(void)
for_each_possible_cpu(i) { for_each_possible_cpu(i) {
void *mem; void *mem;
scratch = raw_cpu_ptr(&scomp_scratch); scratch = per_cpu_ptr(&scomp_scratch, i);
mem = vmalloc_node(SCOMP_SCRATCH_SIZE, cpu_to_node(i)); mem = vmalloc_node(SCOMP_SCRATCH_SIZE, cpu_to_node(i));
if (!mem) if (!mem)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment