Commit 8cbe4b5c authored by Linus Walleij's avatar Linus Walleij Committed by Ralf Baechle

MIPS: TXx9: iocled: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Cc: linux-mips@linux-mips.org
Cc: linux-gpio@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/11925/Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 8eb248fa
...@@ -689,7 +689,7 @@ static int txx9_iocled_get(struct gpio_chip *chip, unsigned int offset) ...@@ -689,7 +689,7 @@ static int txx9_iocled_get(struct gpio_chip *chip, unsigned int offset)
{ {
struct txx9_iocled_data *data = struct txx9_iocled_data *data =
container_of(chip, struct txx9_iocled_data, chip); container_of(chip, struct txx9_iocled_data, chip);
return data->cur_val & (1 << offset); return !!(data->cur_val & (1 << offset));
} }
static void txx9_iocled_set(struct gpio_chip *chip, unsigned int offset, static void txx9_iocled_set(struct gpio_chip *chip, unsigned int offset,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment