Commit 8d2a3539 authored by Changhuang Liang's avatar Changhuang Liang Committed by Vinod Koul

phy: starfive: Correct the dphy configure process

We actually want to calculate the alignment values first, then
use the alignment value to look up the data from reg_configs[].

Fixes: d3ab7955 ("phy: starfive: Add mipi dphy tx support")
Reviewed-by: default avatarShengyang Chen <shengyang.chen@starfivetech.com>
Signed-off-by: default avatarChanghuang Liang <changhuang.liang@starfivetech.com>
Link: https://lore.kernel.org/r/20240627020059.163535-1-changhuang.liang@starfivetech.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 04490b62
...@@ -235,12 +235,14 @@ static int stf_dphy_configure(struct phy *phy, union phy_configure_opts *opts) ...@@ -235,12 +235,14 @@ static int stf_dphy_configure(struct phy *phy, union phy_configure_opts *opts)
const struct stf_dphy_config *p = reg_configs; const struct stf_dphy_config *p = reg_configs;
unsigned long alignment = STF_DPHY_BITRATE_ALIGN; unsigned long alignment = STF_DPHY_BITRATE_ALIGN;
u32 bitrate = opts->mipi_dphy.hs_clk_rate; u32 bitrate = opts->mipi_dphy.hs_clk_rate;
u32 i = stf_dphy_get_config_index(bitrate);
u32 tmp; u32 tmp;
u32 i;
if (bitrate % alignment) if (bitrate % alignment)
bitrate += alignment - (bitrate % alignment); bitrate += alignment - (bitrate % alignment);
i = stf_dphy_get_config_index(bitrate);
tmp = readl(dphy->topsys + STF_DPHY_APBIFSAIF_SYSCFG(100)); tmp = readl(dphy->topsys + STF_DPHY_APBIFSAIF_SYSCFG(100));
tmp &= ~STF_DPHY_REFCLK_IN_SEL; tmp &= ~STF_DPHY_REFCLK_IN_SEL;
tmp |= FIELD_PREP(STF_DPHY_REFCLK_IN_SEL, STF_DPHY_REFCLK_12M); tmp |= FIELD_PREP(STF_DPHY_REFCLK_IN_SEL, STF_DPHY_REFCLK_12M);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment