Commit 8d4ba3f0 authored by Andreas Gruenbacher's avatar Andreas Gruenbacher Committed by Jens Axboe

drbd: Avoid inconsistent locking warning

request_timer_fn() takes resource->req_lock via the device and releases it via
the connection.  Avoid this as it is confusing static code checkers.
Reported-by: default avatar"Dan Carpenter" <dan.carpenter@oracle.com>
Signed-off-by: default avatarAndreas Gruenbacher <agruen@linbit.com>
Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent f0c21e62
...@@ -1645,6 +1645,6 @@ void request_timer_fn(unsigned long data) ...@@ -1645,6 +1645,6 @@ void request_timer_fn(unsigned long data)
? oldest_submit_jif + dt : now + et; ? oldest_submit_jif + dt : now + et;
nt = time_before(ent, dt) ? ent : dt; nt = time_before(ent, dt) ? ent : dt;
out: out:
spin_unlock_irq(&connection->resource->req_lock); spin_unlock_irq(&device->resource->req_lock);
mod_timer(&device->request_timer, nt); mod_timer(&device->request_timer, nt);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment