Commit 8d548ea1 authored by Paolo Abeni's avatar Paolo Abeni Committed by David S. Miller

mptcp: do not set unconditionally csum_reqd on incoming opt

Should be set only if the ingress packets present it, otherwise
we can confuse csum validation.
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarMat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3aa7857f
...@@ -355,8 +355,6 @@ void mptcp_get_options(const struct sock *sk, ...@@ -355,8 +355,6 @@ void mptcp_get_options(const struct sock *sk,
const struct sk_buff *skb, const struct sk_buff *skb,
struct mptcp_options_received *mp_opt) struct mptcp_options_received *mp_opt)
{ {
struct mptcp_subflow_context *subflow = mptcp_subflow_ctx(sk);
struct mptcp_sock *msk = mptcp_sk(subflow->conn);
const struct tcphdr *th = tcp_hdr(skb); const struct tcphdr *th = tcp_hdr(skb);
const unsigned char *ptr; const unsigned char *ptr;
int length; int length;
...@@ -372,7 +370,7 @@ void mptcp_get_options(const struct sock *sk, ...@@ -372,7 +370,7 @@ void mptcp_get_options(const struct sock *sk,
mp_opt->dss = 0; mp_opt->dss = 0;
mp_opt->mp_prio = 0; mp_opt->mp_prio = 0;
mp_opt->reset = 0; mp_opt->reset = 0;
mp_opt->csum_reqd = READ_ONCE(msk->csum_enabled); mp_opt->csum_reqd = 0;
mp_opt->deny_join_id0 = 0; mp_opt->deny_join_id0 = 0;
mp_opt->mp_fail = 0; mp_opt->mp_fail = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment