Commit 8ea274ac authored by Kristian H. Kristensen's avatar Kristian H. Kristensen Committed by Rob Clark

drm/msm: Stop dropping struct_mutex in recover_worker()

Now that we don't have the mmap_sem lock inversion, we don't need to
jump through this particular hoop anymore.
Signed-off-by: default avatarKristian H. Kristensen <hoegsberg@chromium.org>
Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent 48e7f183
...@@ -450,21 +450,8 @@ static void recover_worker(struct work_struct *work) ...@@ -450,21 +450,8 @@ static void recover_worker(struct work_struct *work)
task = get_pid_task(submit->pid, PIDTYPE_PID); task = get_pid_task(submit->pid, PIDTYPE_PID);
if (task) { if (task) {
comm = kstrdup(task->comm, GFP_KERNEL); comm = kstrdup(task->comm, GFP_KERNEL);
/*
* So slightly annoying, in other paths like
* mmap'ing gem buffers, mmap_sem is acquired
* before struct_mutex, which means we can't
* hold struct_mutex across the call to
* get_cmdline(). But submits are retired
* from the same in-order workqueue, so we can
* safely drop the lock here without worrying
* about the submit going away.
*/
mutex_unlock(&dev->struct_mutex);
cmd = kstrdup_quotable_cmdline(task, GFP_KERNEL); cmd = kstrdup_quotable_cmdline(task, GFP_KERNEL);
put_task_struct(task); put_task_struct(task);
mutex_lock(&dev->struct_mutex);
} }
if (comm && cmd) { if (comm && cmd) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment