Commit 8f0c01e6 authored by Necip Fazil Yildiran's avatar Necip Fazil Yildiran Committed by Andy Shevchenko

platform/x86: fix kconfig dependency warning for LG_LAPTOP

When LG_LAPTOP is enabled and NEW_LEDS is disabled, it results in the
following Kbuild warning:

WARNING: unmet direct dependencies detected for LEDS_CLASS
  Depends on [n]: NEW_LEDS [=n]
  Selected by [y]:
  - LG_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && ACPI_WMI [=y] && INPUT [=y]

The reason is that LG_LAPTOP selects LEDS_CLASS without depending on or
selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS.

Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

Fixes: dbf0c5a6 ("platform/x86: Add LG Gram laptop special features driver")
Signed-off-by: default avatarNecip Fazil Yildiran <fazilyildiran@gmail.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Acked-by: default avatarmark gross <mgross@linux.intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 5f38b06d
...@@ -1112,6 +1112,7 @@ config LG_LAPTOP ...@@ -1112,6 +1112,7 @@ config LG_LAPTOP
depends on ACPI_WMI depends on ACPI_WMI
depends on INPUT depends on INPUT
select INPUT_SPARSEKMAP select INPUT_SPARSEKMAP
select NEW_LEDS
select LEDS_CLASS select LEDS_CLASS
help help
This driver adds support for hotkeys as well as control of keyboard This driver adds support for hotkeys as well as control of keyboard
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment