Commit 8fff0427 authored by Andy Shevchenko's avatar Andy Shevchenko

pinctrl: intel: Drop the only label in the code for consistency

Drop the only label in the code, i.e. in intel_config_set_debounce(),
for consistency with the rest. In entire driver we use multipoint
return.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent bb2f43d4
...@@ -695,7 +695,6 @@ static int intel_config_set_debounce(struct intel_pinctrl *pctrl, ...@@ -695,7 +695,6 @@ static int intel_config_set_debounce(struct intel_pinctrl *pctrl,
void __iomem *padcfg0, *padcfg2; void __iomem *padcfg0, *padcfg2;
unsigned long flags; unsigned long flags;
u32 value0, value2; u32 value0, value2;
int ret = 0;
padcfg2 = intel_get_padcfg(pctrl, pin, PADCFG2); padcfg2 = intel_get_padcfg(pctrl, pin, PADCFG2);
if (!padcfg2) if (!padcfg2)
...@@ -717,8 +716,8 @@ static int intel_config_set_debounce(struct intel_pinctrl *pctrl, ...@@ -717,8 +716,8 @@ static int intel_config_set_debounce(struct intel_pinctrl *pctrl,
v = order_base_2(debounce * NSEC_PER_USEC / DEBOUNCE_PERIOD_NSEC); v = order_base_2(debounce * NSEC_PER_USEC / DEBOUNCE_PERIOD_NSEC);
if (v < 3 || v > 15) { if (v < 3 || v > 15) {
ret = -EINVAL; raw_spin_unlock_irqrestore(&pctrl->lock, flags);
goto exit_unlock; return -EINVAL;
} }
/* Enable glitch filter and debouncer */ /* Enable glitch filter and debouncer */
...@@ -730,10 +729,9 @@ static int intel_config_set_debounce(struct intel_pinctrl *pctrl, ...@@ -730,10 +729,9 @@ static int intel_config_set_debounce(struct intel_pinctrl *pctrl,
writel(value0, padcfg0); writel(value0, padcfg0);
writel(value2, padcfg2); writel(value2, padcfg2);
exit_unlock:
raw_spin_unlock_irqrestore(&pctrl->lock, flags); raw_spin_unlock_irqrestore(&pctrl->lock, flags);
return ret; return 0;
} }
static int intel_config_set(struct pinctrl_dev *pctldev, unsigned int pin, static int intel_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment