Commit 90b7c141 authored by Zou Wei's avatar Zou Wei Committed by Wim Van Sebroeck

watchdog: sc520_wdt: Fix possible use-after-free in wdt_turnoff()

This module's remove path calls del_timer(). However, that function
does not wait until the timer handler finishes. This means that the
timer handler may still be running after the driver's remove function
has finished, which would result in a use-after-free.

Fix by calling del_timer_sync(), which makes sure the timer handler
has finished, and unable to re-schedule itself.
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZou Wei <zou_wei@huawei.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/1620716691-108460-1-git-send-email-zou_wei@huawei.comSigned-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent 6ddf5087
...@@ -186,7 +186,7 @@ static int wdt_startup(void) ...@@ -186,7 +186,7 @@ static int wdt_startup(void)
static int wdt_turnoff(void) static int wdt_turnoff(void)
{ {
/* Stop the timer */ /* Stop the timer */
del_timer(&timer); del_timer_sync(&timer);
/* Stop the watchdog */ /* Stop the watchdog */
wdt_config(0); wdt_config(0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment