Commit 9127d4b1 authored by Ingo Molnar's avatar Ingo Molnar Committed by Linus Torvalds

[PATCH] lock debugging: fix DEBUG_LOCKS_WARN_ON() & debug_locks_silent

Matthew Wilcox noticed that the debug_locks_silent use should be inverted
in DEBUG_LOCKS_WARN_ON().  This bug was causing spurious stacktraces and
incorrect failures in the locking self-test on the parisc kernel.
Bug-found-by: default avatarMatthew Wilcox <matthew@wil.cx>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent ba3ff12f
...@@ -24,7 +24,7 @@ extern int debug_locks_off(void); ...@@ -24,7 +24,7 @@ extern int debug_locks_off(void);
int __ret = 0; \ int __ret = 0; \
\ \
if (unlikely(c)) { \ if (unlikely(c)) { \
if (debug_locks_silent || debug_locks_off()) \ if (debug_locks_off() && !debug_locks_silent) \
WARN_ON(1); \ WARN_ON(1); \
__ret = 1; \ __ret = 1; \
} \ } \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment