Commit 918d0aba authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Mark Brown

ASoC: wcd934x: Remove some unnecessary NULL checks

Clang warns:

../sound/soc/codecs/wcd934x.c:1886:11: warning: address of array
'wcd->rx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion]
        if (wcd->rx_chs) {
        ~~  ~~~~~^~~~~~
../sound/soc/codecs/wcd934x.c:1894:11: warning: address of array
'wcd->tx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion]
        if (wcd->tx_chs) {
        ~~  ~~~~~^~~~~~
2 warnings generated.

Arrays that are in the middle of a struct are never NULL so they don't
need a check like this.

Fixes: a61f3b4f ("ASoC: wcd934x: add support to wcd9340/wcd9341 codec")
Link: https://github.com/ClangBuiltLinux/linux/issues/854Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Link: https://lore.kernel.org/r/20200204060143.23393-1-natechancellor@gmail.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent d2cff470
...@@ -1883,20 +1883,16 @@ static int wcd934x_set_channel_map(struct snd_soc_dai *dai, ...@@ -1883,20 +1883,16 @@ static int wcd934x_set_channel_map(struct snd_soc_dai *dai,
return -EINVAL; return -EINVAL;
} }
if (wcd->rx_chs) { wcd->num_rx_port = rx_num;
wcd->num_rx_port = rx_num; for (i = 0; i < rx_num; i++) {
for (i = 0; i < rx_num; i++) { wcd->rx_chs[i].ch_num = rx_slot[i];
wcd->rx_chs[i].ch_num = rx_slot[i]; INIT_LIST_HEAD(&wcd->rx_chs[i].list);
INIT_LIST_HEAD(&wcd->rx_chs[i].list);
}
} }
if (wcd->tx_chs) { wcd->num_tx_port = tx_num;
wcd->num_tx_port = tx_num; for (i = 0; i < tx_num; i++) {
for (i = 0; i < tx_num; i++) { wcd->tx_chs[i].ch_num = tx_slot[i];
wcd->tx_chs[i].ch_num = tx_slot[i]; INIT_LIST_HEAD(&wcd->tx_chs[i].list);
INIT_LIST_HEAD(&wcd->tx_chs[i].list);
}
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment