Commit 927d2cb2 authored by Yazen Ghannam's avatar Yazen Ghannam Committed by Greg Kroah-Hartman

x86/MCE: Add an MCE-record filtering function

commit 45d4b7b9 upstream.

Some systems may report spurious MCA errors. In general, spurious MCA
errors may be disabled by clearing a particular bit in MCA_CTL. However,
clearing a bit in MCA_CTL may not be recommended for some errors, so the
only option is to ignore them.

An MCA error is printed and handled after it has been added to the MCE
event pool. So an MCA error can be ignored by not adding it to that pool
in the first place.

Add such a filtering function.

 [ bp: Move function prototype to the internal header and massage. ]
Signed-off-by: default avatarYazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: "clemej@gmail.com" <clemej@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Pu Wen <puwen@hygon.cn>
Cc: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: "rafal@milecki.pl" <rafal@milecki.pl>
Cc: Shirish S <Shirish.S@amd.com>
Cc: <stable@vger.kernel.org> # 5.0.x
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20190325163410.171021-1-Yazen.Ghannam@amd.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0a62aaee
...@@ -1771,6 +1771,11 @@ static void __mcheck_cpu_init_timer(void) ...@@ -1771,6 +1771,11 @@ static void __mcheck_cpu_init_timer(void)
mce_start_timer(t); mce_start_timer(t);
} }
bool filter_mce(struct mce *m)
{
return false;
}
/* Handle unconfigured int18 (should never happen) */ /* Handle unconfigured int18 (should never happen) */
static void unexpected_machine_check(struct pt_regs *regs, long error_code) static void unexpected_machine_check(struct pt_regs *regs, long error_code)
{ {
......
...@@ -99,6 +99,9 @@ int mce_gen_pool_add(struct mce *mce) ...@@ -99,6 +99,9 @@ int mce_gen_pool_add(struct mce *mce)
{ {
struct mce_evt_llist *node; struct mce_evt_llist *node;
if (filter_mce(mce))
return -EINVAL;
if (!mce_evt_pool) if (!mce_evt_pool)
return -EINVAL; return -EINVAL;
......
...@@ -173,4 +173,7 @@ struct mca_msr_regs { ...@@ -173,4 +173,7 @@ struct mca_msr_regs {
extern struct mca_msr_regs msr_ops; extern struct mca_msr_regs msr_ops;
/* Decide whether to add MCE record to MCE event pool or filter it out. */
extern bool filter_mce(struct mce *m);
#endif /* __X86_MCE_INTERNAL_H__ */ #endif /* __X86_MCE_INTERNAL_H__ */
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment