Commit 92937241 authored by Boris Ostrovsky's avatar Boris Ostrovsky

xen/gntdev: Do not use mm notifiers with autotranslating guests

Commit d3eeb1d7 ("xen/gntdev: use mmu_interval_notifier_insert")
missed a test for use_ptemod when calling mmu_interval_read_begin(). Fix
that.

Fixes: d3eeb1d7 ("xen/gntdev: use mmu_interval_notifier_insert")
CC: stable@vger.kernel.org # 5.5
Reported-by: default avatarIlpo Järvinen <ilpo.jarvinen@cs.helsinki.fi>
Tested-by: default avatarIlpo Järvinen <ilpo.jarvinen@cs.helsinki.fi>
Signed-off-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@mellanox.com>
Acked-by: default avatarJuergen Gross <jgross@suse.com>
parent eda4eabf
...@@ -1006,19 +1006,19 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) ...@@ -1006,19 +1006,19 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
} }
mutex_unlock(&priv->lock); mutex_unlock(&priv->lock);
if (use_ptemod) {
/* /*
* gntdev takes the address of the PTE in find_grant_ptes() and passes * gntdev takes the address of the PTE in find_grant_ptes() and
* it to the hypervisor in gntdev_map_grant_pages(). The purpose of * passes it to the hypervisor in gntdev_map_grant_pages(). The
* the notifier is to prevent the hypervisor pointer to the PTE from * purpose of the notifier is to prevent the hypervisor pointer
* going stale. * to the PTE from going stale.
* *
* Since this vma's mappings can't be touched without the mmap_sem, * Since this vma's mappings can't be touched without the
* and we are holding it now, there is no need for the notifier_range * mmap_sem, and we are holding it now, there is no need for
* locking pattern. * the notifier_range locking pattern.
*/ */
mmu_interval_read_begin(&map->notifier); mmu_interval_read_begin(&map->notifier);
if (use_ptemod) {
map->pages_vm_start = vma->vm_start; map->pages_vm_start = vma->vm_start;
err = apply_to_page_range(vma->vm_mm, vma->vm_start, err = apply_to_page_range(vma->vm_mm, vma->vm_start,
vma->vm_end - vma->vm_start, vma->vm_end - vma->vm_start,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment