Commit 93408be9 authored by Felipe Balbi's avatar Felipe Balbi Committed by Zefan Li

usb: dwc3: core: fix order of PM runtime calls

commit fed33afc upstream.

Currently, we disable pm_runtime before all register
accesses are done, this is dangerous and might lead
to abort exceptions due to the driver trying to access
a register which is clocked by a clock which was long
gated.

Fix that by moving pm_runtime_put_sync() and pm_runtime_disable()
as the last thing we do before returning from our ->remove()
method.

Fixes: 72246da4 (usb: Introduce DesignWare USB3 DRD Driver)
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
[lizf: Backported to 3.4: adjust context]
Signed-off-by: default avatarZefan Li <lizefan@huawei.com>
parent 45b95d16
...@@ -563,9 +563,6 @@ static int __devexit dwc3_remove(struct platform_device *pdev) ...@@ -563,9 +563,6 @@ static int __devexit dwc3_remove(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev);
dwc3_debugfs_exit(dwc); dwc3_debugfs_exit(dwc);
switch (dwc->mode) { switch (dwc->mode) {
...@@ -586,6 +583,9 @@ static int __devexit dwc3_remove(struct platform_device *pdev) ...@@ -586,6 +583,9 @@ static int __devexit dwc3_remove(struct platform_device *pdev)
dwc3_core_exit(dwc); dwc3_core_exit(dwc);
pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment