Commit 938f65ad authored by Alexander Stein's avatar Alexander Stein Committed by Jakub Kicinski

net: phy: dp83867: Add led_brightness_set support

Up to 4 LEDs can be attached to the PHY, add support for setting
brightness manually.
Signed-off-by: default avatarAlexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20230424134625.303957-1-alexander.stein@ew.tq-group.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent aed8fdad
...@@ -26,6 +26,8 @@ ...@@ -26,6 +26,8 @@
#define MII_DP83867_MICR 0x12 #define MII_DP83867_MICR 0x12
#define MII_DP83867_ISR 0x13 #define MII_DP83867_ISR 0x13
#define DP83867_CFG2 0x14 #define DP83867_CFG2 0x14
#define DP83867_LEDCR1 0x18
#define DP83867_LEDCR2 0x19
#define DP83867_CFG3 0x1e #define DP83867_CFG3 0x1e
#define DP83867_CTRL 0x1f #define DP83867_CTRL 0x1f
...@@ -150,6 +152,12 @@ ...@@ -150,6 +152,12 @@
/* FLD_THR_CFG */ /* FLD_THR_CFG */
#define DP83867_FLD_THR_CFG_ENERGY_LOST_THR_MASK 0x7 #define DP83867_FLD_THR_CFG_ENERGY_LOST_THR_MASK 0x7
#define DP83867_LED_COUNT 4
/* LED_DRV bits */
#define DP83867_LED_DRV_EN(x) BIT((x) * 4)
#define DP83867_LED_DRV_VAL(x) BIT((x) * 4 + 1)
enum { enum {
DP83867_PORT_MIRROING_KEEP, DP83867_PORT_MIRROING_KEEP,
DP83867_PORT_MIRROING_EN, DP83867_PORT_MIRROING_EN,
...@@ -969,6 +977,27 @@ static int dp83867_loopback(struct phy_device *phydev, bool enable) ...@@ -969,6 +977,27 @@ static int dp83867_loopback(struct phy_device *phydev, bool enable)
enable ? BMCR_LOOPBACK : 0); enable ? BMCR_LOOPBACK : 0);
} }
static int
dp83867_led_brightness_set(struct phy_device *phydev,
u8 index, enum led_brightness brightness)
{
u32 val;
if (index >= DP83867_LED_COUNT)
return -EINVAL;
/* DRV_EN==1: output is DRV_VAL */
val = DP83867_LED_DRV_EN(index);
if (brightness)
val |= DP83867_LED_DRV_VAL(index);
return phy_modify(phydev, DP83867_LEDCR2,
DP83867_LED_DRV_VAL(index) |
DP83867_LED_DRV_EN(index),
val);
}
static struct phy_driver dp83867_driver[] = { static struct phy_driver dp83867_driver[] = {
{ {
.phy_id = DP83867_PHY_ID, .phy_id = DP83867_PHY_ID,
...@@ -996,6 +1025,8 @@ static struct phy_driver dp83867_driver[] = { ...@@ -996,6 +1025,8 @@ static struct phy_driver dp83867_driver[] = {
.link_change_notify = dp83867_link_change_notify, .link_change_notify = dp83867_link_change_notify,
.set_loopback = dp83867_loopback, .set_loopback = dp83867_loopback,
.led_brightness_set = dp83867_led_brightness_set,
}, },
}; };
module_phy_driver(dp83867_driver); module_phy_driver(dp83867_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment