Commit 952ab431 authored by Jesper Juhl's avatar Jesper Juhl Committed by Greg Kroah-Hartman

Driver core: Don't leak 'old_class_name' in drivers/base/core.c::device_rename()

If kmalloc() fails to allocate space for 'old_symlink_name' in
drivers/base/core.c::device_rename(), then we'll leak 'old_class_name'.

Spotted by the Coverity checker.
Signed-off-by: default avatarJesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 221c324a
...@@ -809,8 +809,10 @@ int device_rename(struct device *dev, char *new_name) ...@@ -809,8 +809,10 @@ int device_rename(struct device *dev, char *new_name)
if (dev->class) { if (dev->class) {
old_symlink_name = kmalloc(BUS_ID_SIZE, GFP_KERNEL); old_symlink_name = kmalloc(BUS_ID_SIZE, GFP_KERNEL);
if (!old_symlink_name) if (!old_symlink_name) {
return -ENOMEM; error = -ENOMEM;
goto out_free_old_class;
}
strlcpy(old_symlink_name, dev->bus_id, BUS_ID_SIZE); strlcpy(old_symlink_name, dev->bus_id, BUS_ID_SIZE);
} }
...@@ -834,9 +836,10 @@ int device_rename(struct device *dev, char *new_name) ...@@ -834,9 +836,10 @@ int device_rename(struct device *dev, char *new_name)
} }
put_device(dev); put_device(dev);
kfree(old_class_name);
kfree(new_class_name); kfree(new_class_name);
kfree(old_symlink_name); kfree(old_symlink_name);
out_free_old_class:
kfree(old_class_name);
return error; return error;
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment