Commit 957ccc43 authored by Maciej S. Szmigiero's avatar Maciej S. Szmigiero Committed by Takashi Iwai

ALSA: ca0106: Use snd_ctl_rename() to rename a control

With the recent addition of hashed controls lookup it's not enough to just
update the control name field, the hash entries for the modified control
have to be updated too.

snd_ctl_rename() takes care of that, so use it instead of directly
modifying the control name.

Fixes: c27e1efb ("ALSA: control: Use xarray for faster lookups")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMaciej S. Szmigiero <maciej.szmigiero@oracle.com>
Link: https://lore.kernel.org/r/bffee980a420f9b0eee5681d2f48d34a70cec0ce.1666296963.git.maciej.szmigiero@oracle.comSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 36476b81
...@@ -720,7 +720,7 @@ static int rename_ctl(struct snd_card *card, const char *src, const char *dst) ...@@ -720,7 +720,7 @@ static int rename_ctl(struct snd_card *card, const char *src, const char *dst)
{ {
struct snd_kcontrol *kctl = ctl_find(card, src); struct snd_kcontrol *kctl = ctl_find(card, src);
if (kctl) { if (kctl) {
strcpy(kctl->id.name, dst); snd_ctl_rename(card, kctl, dst);
return 0; return 0;
} }
return -ENOENT; return -ENOENT;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment