Commit 95c75454 authored by Jesper Juhl's avatar Jesper Juhl Committed by Jiri Kosina

CIFS: Don't free volume_info->UNC until we are entirely done with it.

In cleanup_volume_info_contents() we kfree(volume_info->UNC); and then
proceed to use that variable on the very next line.
This causes (at least) Coverity Prevent to complain about use-after-free
of that variable (and I guess other checkers may do that as well).
There's not any /real/ problem here since we are just using the value of
the pointer, not actually dereferencing it, but it's still trivial to
silence the tool, so why not?
To me at least it also just seems nicer to defer freeing the variable
until we are entirely done with it in all respects.
Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Reviewed-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent bfb9035c
...@@ -2877,9 +2877,9 @@ cleanup_volume_info_contents(struct smb_vol *volume_info) ...@@ -2877,9 +2877,9 @@ cleanup_volume_info_contents(struct smb_vol *volume_info)
{ {
kfree(volume_info->username); kfree(volume_info->username);
kzfree(volume_info->password); kzfree(volume_info->password);
kfree(volume_info->UNC);
if (volume_info->UNCip != volume_info->UNC + 2) if (volume_info->UNCip != volume_info->UNC + 2)
kfree(volume_info->UNCip); kfree(volume_info->UNCip);
kfree(volume_info->UNC);
kfree(volume_info->domainname); kfree(volume_info->domainname);
kfree(volume_info->iocharset); kfree(volume_info->iocharset);
kfree(volume_info->prepath); kfree(volume_info->prepath);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment