Commit 95e34412 authored by Minchan Kim's avatar Minchan Kim Committed by Linus Torvalds

mm: remain migratetype in freed page

The page allocator caches the pageblock information in page->private while
it is in the PCP freelists but this is overwritten with the order of the
page when freed to the buddy allocator.  This patch stores the migratetype
of the page in the page->index field so that it is available at all times
when the page remain in free_list.

This patch adds a new call site in __free_pages_ok so it might be overhead
a bit but it's for high order allocation.  So I believe damage isn't hurt.
Signed-off-by: default avatarMinchan Kim <minchan@kernel.org>
Acked-by: default avatarKAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Reviewed-by: default avatarYasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Acked-by: default avatarMel Gorman <mgorman@suse.de>
Cc: Xishi Qiu <qiuxishi@huawei.com>
Cc: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b12c4ad1
...@@ -240,13 +240,13 @@ struct inode; ...@@ -240,13 +240,13 @@ struct inode;
/* It's valid only if the page is free path or free_list */ /* It's valid only if the page is free path or free_list */
static inline void set_freepage_migratetype(struct page *page, int migratetype) static inline void set_freepage_migratetype(struct page *page, int migratetype)
{ {
set_page_private(page, migratetype); page->index = migratetype;
} }
/* It's valid only if the page is free path or free_list */ /* It's valid only if the page is free path or free_list */
static inline int get_freepage_migratetype(struct page *page) static inline int get_freepage_migratetype(struct page *page)
{ {
return page_private(page); return page->index;
} }
/* /*
......
...@@ -729,6 +729,7 @@ static void __free_pages_ok(struct page *page, unsigned int order) ...@@ -729,6 +729,7 @@ static void __free_pages_ok(struct page *page, unsigned int order)
{ {
unsigned long flags; unsigned long flags;
int wasMlocked = __TestClearPageMlocked(page); int wasMlocked = __TestClearPageMlocked(page);
int migratetype;
if (!free_pages_prepare(page, order)) if (!free_pages_prepare(page, order))
return; return;
...@@ -737,8 +738,9 @@ static void __free_pages_ok(struct page *page, unsigned int order) ...@@ -737,8 +738,9 @@ static void __free_pages_ok(struct page *page, unsigned int order)
if (unlikely(wasMlocked)) if (unlikely(wasMlocked))
free_page_mlock(page); free_page_mlock(page);
__count_vm_events(PGFREE, 1 << order); __count_vm_events(PGFREE, 1 << order);
free_one_page(page_zone(page), page, order, migratetype = get_pageblock_migratetype(page);
get_pageblock_migratetype(page)); set_freepage_migratetype(page, migratetype);
free_one_page(page_zone(page), page, order, migratetype);
local_irq_restore(flags); local_irq_restore(flags);
} }
...@@ -959,6 +961,7 @@ static int move_freepages(struct zone *zone, ...@@ -959,6 +961,7 @@ static int move_freepages(struct zone *zone,
order = page_order(page); order = page_order(page);
list_move(&page->lru, list_move(&page->lru,
&zone->free_area[order].free_list[migratetype]); &zone->free_area[order].free_list[migratetype]);
set_freepage_migratetype(page, migratetype);
page += 1 << order; page += 1 << order;
pages_moved += 1 << order; pages_moved += 1 << order;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment