Commit 95ecdc25 authored by Javier Martinez Canillas's avatar Javier Martinez Canillas Committed by Dmitry Torokhov

Input: cros_ec_keyb - replace KEYBOARD_CROS_EC dependency

The ChromeOS EC keyboard driver config depends on CROS_EC_PROTO but
MFD_CROS_EC selects CROS_EC_PROTO instead. Mixing select and depends
on is bad practice as it may lead to circular Kconfig dependencies.

Since the platform device that is matched with the keyboard driver
is registered by the ChromeOS EC mfd driver, KEYBOARD_CROS_EC really
should depend on MFD_CROS_EC. And because this config option selects
CROS_EC_PROTO, that dependency is met as well. So make the driver
to depend on MFD_CROS_EC instead of CROS_EC_PROTO.
Signed-off-by: default avatarJavier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent efe3b616
...@@ -678,7 +678,7 @@ config KEYBOARD_W90P910 ...@@ -678,7 +678,7 @@ config KEYBOARD_W90P910
config KEYBOARD_CROS_EC config KEYBOARD_CROS_EC
tristate "ChromeOS EC keyboard" tristate "ChromeOS EC keyboard"
select INPUT_MATRIXKMAP select INPUT_MATRIXKMAP
depends on CROS_EC_PROTO depends on MFD_CROS_EC
help help
Say Y here to enable the matrix keyboard used by ChromeOS devices Say Y here to enable the matrix keyboard used by ChromeOS devices
and implemented on the ChromeOS EC. You must enable one bus option and implemented on the ChromeOS EC. You must enable one bus option
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment