Commit 95edbbf7 authored by Yang Yingliang's avatar Yang Yingliang Committed by Hans de Goede

platform/x86: amd-pmc: Fix missing unlock on error in amd_pmc_send_cmd()

Add the missing unlock before return from function amd_pmc_send_cmd()
in the error handling case.

Fixes: 95e1b60f ("platform/x86: amd-pmc: Fix command completion code")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210715074327.1966083-1-yangyingliang@huawei.comSigned-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 23e9592b
...@@ -275,7 +275,7 @@ static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, bool set, u32 *data, u8 msg ...@@ -275,7 +275,7 @@ static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, bool set, u32 *data, u8 msg
PMC_MSG_DELAY_MIN_US * RESPONSE_REGISTER_LOOP_MAX); PMC_MSG_DELAY_MIN_US * RESPONSE_REGISTER_LOOP_MAX);
if (rc) { if (rc) {
dev_err(dev->dev, "failed to talk to SMU\n"); dev_err(dev->dev, "failed to talk to SMU\n");
return rc; goto out_unlock;
} }
/* Write zero to response register */ /* Write zero to response register */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment