Commit 9647507a authored by Jacek Anaszewski's avatar Jacek Anaszewski Committed by Bryan Wu

leds: flash: Fix the size of sysfs_groups array

LED_FLASH_MAX_SYSFS_GROUPS macro had value that was relevant for
previous version of the patches introducing LED Flash class. Currently
it is required to reserve the room for maximum 4 sysfs groups.
Since the last element of the struct attribute_group array passed to
the function device_create_with_groups has to be NULL, the size of the
array has to be greater by one than maximum allowed number of groups.
Therefore, the name of the macro is being changed to
LED_FLASH_SYSFS_GROUPS_SIZE, to make it more accurrate.
Signed-off-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
Acked-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Cc: Bryan Wu <cooloney@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: default avatarBryan Wu <cooloney@gmail.com>
parent f6ad395b
...@@ -32,7 +32,7 @@ struct led_classdev_flash; ...@@ -32,7 +32,7 @@ struct led_classdev_flash;
#define LED_FAULT_LED_OVER_TEMPERATURE (1 << 8) #define LED_FAULT_LED_OVER_TEMPERATURE (1 << 8)
#define LED_NUM_FLASH_FAULTS 9 #define LED_NUM_FLASH_FAULTS 9
#define LED_FLASH_MAX_SYSFS_GROUPS 7 #define LED_FLASH_SYSFS_GROUPS_SIZE 5
struct led_flash_ops { struct led_flash_ops {
/* set flash brightness */ /* set flash brightness */
...@@ -80,7 +80,7 @@ struct led_classdev_flash { ...@@ -80,7 +80,7 @@ struct led_classdev_flash {
struct led_flash_setting timeout; struct led_flash_setting timeout;
/* LED Flash class sysfs groups */ /* LED Flash class sysfs groups */
const struct attribute_group *sysfs_groups[LED_FLASH_MAX_SYSFS_GROUPS]; const struct attribute_group *sysfs_groups[LED_FLASH_SYSFS_GROUPS_SIZE];
}; };
static inline struct led_classdev_flash *lcdev_to_flcdev( static inline struct led_classdev_flash *lcdev_to_flcdev(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment