Commit 9675ee5a authored by Andi Shyti's avatar Andi Shyti Committed by Mauro Carvalho Chehab

[media] lirc_dev: fix variable constant comparisons

When comparing a variable with a constant, the comparison should
start from the variable and not from the constant. It's also
written in the human DNA.

Swap the terms of comparisons whenever the constant comes first
and fix the following checkpatch warning:

  WARNING: Comparisons should place the constant on the right side of the test
Signed-off-by: default avatarAndi Shyti <andi.shyti@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 14db9fc2
...@@ -248,13 +248,13 @@ static int lirc_allocate_driver(struct lirc_driver *d) ...@@ -248,13 +248,13 @@ static int lirc_allocate_driver(struct lirc_driver *d)
return -EINVAL; return -EINVAL;
} }
if (MAX_IRCTL_DEVICES <= d->minor) { if (d->minor >= MAX_IRCTL_DEVICES) {
dev_err(d->dev, "minor must be between 0 and %d!\n", dev_err(d->dev, "minor must be between 0 and %d!\n",
MAX_IRCTL_DEVICES - 1); MAX_IRCTL_DEVICES - 1);
return -EBADRQC; return -EBADRQC;
} }
if (1 > d->code_length || (BUFLEN * 8) < d->code_length) { if (d->code_length < 1 || d->code_length > (BUFLEN * 8)) {
dev_err(d->dev, "code length must be less than %d bits\n", dev_err(d->dev, "code length must be less than %d bits\n",
BUFLEN * 8); BUFLEN * 8);
return -EBADRQC; return -EBADRQC;
...@@ -285,7 +285,7 @@ static int lirc_allocate_driver(struct lirc_driver *d) ...@@ -285,7 +285,7 @@ static int lirc_allocate_driver(struct lirc_driver *d)
for (minor = 0; minor < MAX_IRCTL_DEVICES; minor++) for (minor = 0; minor < MAX_IRCTL_DEVICES; minor++)
if (!irctls[minor]) if (!irctls[minor])
break; break;
if (MAX_IRCTL_DEVICES == minor) { if (minor == MAX_IRCTL_DEVICES) {
dev_err(d->dev, "no free slots for drivers!\n"); dev_err(d->dev, "no free slots for drivers!\n");
err = -ENOMEM; err = -ENOMEM;
goto out_lock; goto out_lock;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment