Commit 97130700 authored by Zhen Lei's avatar Zhen Lei Committed by Arnaldo Carvalho de Melo

perf diff: Fix error return value in __cmd_diff()

An appropriate return value should be set on the failed path.

Fixes: 2a09a84c ("perf diff: Support hot streams comparison")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20201124103652.438-1-thunder.leizhen@huawei.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 3b13eaf0
...@@ -1222,10 +1222,12 @@ static int __cmd_diff(void) ...@@ -1222,10 +1222,12 @@ static int __cmd_diff(void)
if (compute == COMPUTE_STREAM) { if (compute == COMPUTE_STREAM) {
d->evlist_streams = evlist__create_streams( d->evlist_streams = evlist__create_streams(
d->session->evlist, 5); d->session->evlist, 5);
if (!d->evlist_streams) if (!d->evlist_streams) {
ret = -ENOMEM;
goto out_delete; goto out_delete;
} }
} }
}
if (compute == COMPUTE_STREAM) if (compute == COMPUTE_STREAM)
stream_process(); stream_process();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment