Commit 97a0c313 authored by Markus Elfring's avatar Markus Elfring Committed by Ulf Hansson

mmc: core: Use memdup_user() rather than duplicating its implementation

Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.

This issue was detected by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent e988867f
...@@ -375,22 +375,15 @@ static struct mmc_blk_ioc_data *mmc_blk_ioctl_copy_from_user( ...@@ -375,22 +375,15 @@ static struct mmc_blk_ioc_data *mmc_blk_ioctl_copy_from_user(
return idata; return idata;
} }
idata->buf = kmalloc(idata->buf_bytes, GFP_KERNEL); idata->buf = memdup_user((void __user *)(unsigned long)
if (!idata->buf) { idata->ic.data_ptr, idata->buf_bytes);
err = -ENOMEM; if (IS_ERR(idata->buf)) {
err = PTR_ERR(idata->buf);
goto idata_err; goto idata_err;
} }
if (copy_from_user(idata->buf, (void __user *)(unsigned long)
idata->ic.data_ptr, idata->buf_bytes)) {
err = -EFAULT;
goto copy_err;
}
return idata; return idata;
copy_err:
kfree(idata->buf);
idata_err: idata_err:
kfree(idata); kfree(idata);
out: out:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment