Commit 97a93b2b authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Herbert Xu

crypto: cavium/nitrox - no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Srikanth Jampala <Jampala.Srikanth@cavium.com>
Cc: Yangtao Li <tiny.windzz@gmail.com>
Cc: Gadam Sreerama <sgadam@cavium.com>
Cc: Eric Biggers <ebiggers@google.com>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent e30886b4
...@@ -55,31 +55,14 @@ void nitrox_debugfs_exit(struct nitrox_device *ndev) ...@@ -55,31 +55,14 @@ void nitrox_debugfs_exit(struct nitrox_device *ndev)
ndev->debugfs_dir = NULL; ndev->debugfs_dir = NULL;
} }
int nitrox_debugfs_init(struct nitrox_device *ndev) void nitrox_debugfs_init(struct nitrox_device *ndev)
{ {
struct dentry *dir, *f; struct dentry *dir;
dir = debugfs_create_dir(KBUILD_MODNAME, NULL); dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
if (!dir)
return -ENOMEM;
ndev->debugfs_dir = dir; ndev->debugfs_dir = dir;
f = debugfs_create_file("firmware", 0400, dir, ndev, debugfs_create_file("firmware", 0400, dir, ndev, &firmware_fops);
&firmware_fops); debugfs_create_file("device", 0400, dir, ndev, &device_fops);
if (!f) debugfs_create_file("stats", 0400, dir, ndev, &stats_fops);
goto err;
f = debugfs_create_file("device", 0400, dir, ndev,
&device_fops);
if (!f)
goto err;
f = debugfs_create_file("stats", 0400, dir, ndev,
&stats_fops);
if (!f)
goto err;
return 0;
err:
nitrox_debugfs_exit(ndev);
return -ENODEV;
} }
...@@ -5,12 +5,11 @@ ...@@ -5,12 +5,11 @@
#include "nitrox_dev.h" #include "nitrox_dev.h"
#ifdef CONFIG_DEBUG_FS #ifdef CONFIG_DEBUG_FS
int nitrox_debugfs_init(struct nitrox_device *ndev); void nitrox_debugfs_init(struct nitrox_device *ndev);
void nitrox_debugfs_exit(struct nitrox_device *ndev); void nitrox_debugfs_exit(struct nitrox_device *ndev);
#else #else
static inline int nitrox_debugfs_init(struct nitrox_device *ndev) static inline void nitrox_debugfs_init(struct nitrox_device *ndev)
{ {
return 0;
} }
static inline void nitrox_debugfs_exit(struct nitrox_device *ndev) static inline void nitrox_debugfs_exit(struct nitrox_device *ndev)
......
...@@ -404,9 +404,7 @@ static int nitrox_probe(struct pci_dev *pdev, ...@@ -404,9 +404,7 @@ static int nitrox_probe(struct pci_dev *pdev,
if (err) if (err)
goto pf_hw_fail; goto pf_hw_fail;
err = nitrox_debugfs_init(ndev); nitrox_debugfs_init(ndev);
if (err)
goto pf_hw_fail;
/* clear the statistics */ /* clear the statistics */
atomic64_set(&ndev->stats.posted, 0); atomic64_set(&ndev->stats.posted, 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment