Commit 97ced1aa authored by Finn Thain's avatar Finn Thain Committed by Michael Ellerman

via-cuda: Initialize data_index early and increment consistently

Initialize data_index where appropriate to improve readability and
assist debugging. This change doesn't affect driver behaviour.

I prefer to see
	current_req->data[data_index++]
in place of
	current_req->data[0]
or
	current_req->data[1]
inasmuchas it becomes obvious what the data_index variable does.

Moreover, the actual value of data_index when examined at any given moment
tells me something about prior events, which did prove helpful.
Tested-by: default avatarStan Johnson <userm57@yahoo.com>
Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent ac39452e
...@@ -446,12 +446,13 @@ cuda_start(void) ...@@ -446,12 +446,13 @@ cuda_start(void)
/* assert cuda_state == idle */ /* assert cuda_state == idle */
if (current_req == NULL) if (current_req == NULL)
return; return;
data_index = 0;
if (TREQ_asserted(in_8(&via[B]))) if (TREQ_asserted(in_8(&via[B])))
return; /* a byte is coming in from the CUDA */ return; /* a byte is coming in from the CUDA */
/* set the shift register to shift out and send a byte */ /* set the shift register to shift out and send a byte */
out_8(&via[ACR], in_8(&via[ACR]) | SR_OUT); out_8(&via[ACR], in_8(&via[ACR]) | SR_OUT);
out_8(&via[SR], current_req->data[0]); out_8(&via[SR], current_req->data[data_index++]);
assert_TIP(); assert_TIP();
cuda_state = sent_first_byte; cuda_state = sent_first_byte;
} }
...@@ -524,9 +525,8 @@ cuda_interrupt(int irq, void *arg) ...@@ -524,9 +525,8 @@ cuda_interrupt(int irq, void *arg)
negate_TIP_and_TACK(); negate_TIP_and_TACK();
cuda_state = idle; cuda_state = idle;
} else { } else {
out_8(&via[SR], current_req->data[1]); out_8(&via[SR], current_req->data[data_index++]);
toggle_TACK(); toggle_TACK();
data_index = 2;
cuda_state = sending; cuda_state = sending;
} }
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment