Commit 97ec4d55 authored by Linus Torvalds's avatar Linus Torvalds

Merge tag 'block-6.2-2023-01-13' of git://git.kernel.dk/linux

Pull block fixes from Jens Axboe:
 "Nothing major in here, just a collection of NVMe fixes and dropping a
  wrong might_sleep() that static checkers tripped over but which isn't
  valid"

* tag 'block-6.2-2023-01-13' of git://git.kernel.dk/linux:
  MAINTAINERS: stop nvme matching for nvmem files
  nvme: don't allow unprivileged passthrough on partitions
  nvme: replace the "bool vec" arguments with flags in the ioctl path
  nvme: remove __nvme_ioctl
  nvme-pci: fix error handling in nvme_pci_enable()
  nvme-pci: add NVME_QUIRK_IDENTIFY_CNS quirk to Apple T2 controllers
  nvme-apple: add NVME_QUIRK_IDENTIFY_CNS quirk to fix regression
  block: Drop spurious might_sleep() from blk_put_queue()
parents 2ce7592d 3d25b1e8
...@@ -14919,7 +14919,8 @@ T: git://git.infradead.org/nvme.git ...@@ -14919,7 +14919,8 @@ T: git://git.infradead.org/nvme.git
F: Documentation/nvme/ F: Documentation/nvme/
F: drivers/nvme/host/ F: drivers/nvme/host/
F: drivers/nvme/common/ F: drivers/nvme/common/
F: include/linux/nvme* F: include/linux/nvme.h
F: include/linux/nvme-*.h
F: include/uapi/linux/nvme_ioctl.h F: include/uapi/linux/nvme_ioctl.h
NVM EXPRESS FABRICS AUTHENTICATION NVM EXPRESS FABRICS AUTHENTICATION
......
...@@ -283,12 +283,9 @@ static void blk_free_queue(struct request_queue *q) ...@@ -283,12 +283,9 @@ static void blk_free_queue(struct request_queue *q)
* *
* Decrements the refcount of the request_queue and free it when the refcount * Decrements the refcount of the request_queue and free it when the refcount
* reaches 0. * reaches 0.
*
* Context: Can sleep.
*/ */
void blk_put_queue(struct request_queue *q) void blk_put_queue(struct request_queue *q)
{ {
might_sleep();
if (refcount_dec_and_test(&q->refs)) if (refcount_dec_and_test(&q->refs))
blk_free_queue(q); blk_free_queue(q);
} }
......
...@@ -1493,7 +1493,7 @@ static int apple_nvme_probe(struct platform_device *pdev) ...@@ -1493,7 +1493,7 @@ static int apple_nvme_probe(struct platform_device *pdev)
} }
ret = nvme_init_ctrl(&anv->ctrl, anv->dev, &nvme_ctrl_ops, ret = nvme_init_ctrl(&anv->ctrl, anv->dev, &nvme_ctrl_ops,
NVME_QUIRK_SKIP_CID_GEN); NVME_QUIRK_SKIP_CID_GEN | NVME_QUIRK_IDENTIFY_CNS);
if (ret) { if (ret) {
dev_err_probe(dev, ret, "Failed to initialize nvme_ctrl"); dev_err_probe(dev, ret, "Failed to initialize nvme_ctrl");
goto put_dev; goto put_dev;
......
This diff is collapsed.
...@@ -2533,7 +2533,7 @@ static int nvme_pci_enable(struct nvme_dev *dev) ...@@ -2533,7 +2533,7 @@ static int nvme_pci_enable(struct nvme_dev *dev)
*/ */
result = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES); result = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
if (result < 0) if (result < 0)
return result; goto disable;
dev->ctrl.cap = lo_hi_readq(dev->bar + NVME_REG_CAP); dev->ctrl.cap = lo_hi_readq(dev->bar + NVME_REG_CAP);
...@@ -2586,8 +2586,13 @@ static int nvme_pci_enable(struct nvme_dev *dev) ...@@ -2586,8 +2586,13 @@ static int nvme_pci_enable(struct nvme_dev *dev)
pci_enable_pcie_error_reporting(pdev); pci_enable_pcie_error_reporting(pdev);
pci_save_state(pdev); pci_save_state(pdev);
return nvme_pci_configure_admin_queue(dev); result = nvme_pci_configure_admin_queue(dev);
if (result)
goto free_irq;
return result;
free_irq:
pci_free_irq_vectors(pdev);
disable: disable:
pci_disable_device(pdev); pci_disable_device(pdev);
return result; return result;
...@@ -3495,7 +3500,8 @@ static const struct pci_device_id nvme_id_table[] = { ...@@ -3495,7 +3500,8 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_SINGLE_VECTOR | .driver_data = NVME_QUIRK_SINGLE_VECTOR |
NVME_QUIRK_128_BYTES_SQES | NVME_QUIRK_128_BYTES_SQES |
NVME_QUIRK_SHARED_TAGS | NVME_QUIRK_SHARED_TAGS |
NVME_QUIRK_SKIP_CID_GEN }, NVME_QUIRK_SKIP_CID_GEN |
NVME_QUIRK_IDENTIFY_CNS },
{ PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) }, { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
{ 0, } { 0, }
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment