Commit 9a6bc7f9 authored by Takashi Iwai's avatar Takashi Iwai Committed by Sasha Levin

ALSA: au88x0: Fix calculation in vortex_wtdma_bufshift()

[ Upstream commit 62db7152 ]

vortex_wtdma_bufshift() function does calculate the page index
wrongly, first masking then shift, which always results in zero.
The proper computation is to first shift, then mask.
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
parent 9e0303eb
...@@ -1444,9 +1444,8 @@ static int vortex_wtdma_bufshift(vortex_t * vortex, int wtdma) ...@@ -1444,9 +1444,8 @@ static int vortex_wtdma_bufshift(vortex_t * vortex, int wtdma)
int page, p, pp, delta, i; int page, p, pp, delta, i;
page = page =
(hwread(vortex->mmio, VORTEX_WTDMA_STAT + (wtdma << 2)) & (hwread(vortex->mmio, VORTEX_WTDMA_STAT + (wtdma << 2))
WT_SUBBUF_MASK) >> WT_SUBBUF_SHIFT) & WT_SUBBUF_MASK;
>> WT_SUBBUF_SHIFT;
if (dma->nr_periods >= 4) if (dma->nr_periods >= 4)
delta = (page - dma->period_real) & 3; delta = (page - dma->period_real) & 3;
else { else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment