Commit 9aa66382 authored by Nikolay Aleksandrov's avatar Nikolay Aleksandrov Committed by David S. Miller

bridge: multicast: add a comment to br_port_state_selection about blocking state

Add a comment to explain why we're not disabling port's multicast when it
goes in blocking state. Since there's a check in the timer's function which
bypasses the timer if the port's in blocking/disabled state, the timer will
simply expire and stop without sending more queries.
Suggested-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Acked-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3a07bd6f
...@@ -463,6 +463,10 @@ void br_port_state_selection(struct net_bridge *br) ...@@ -463,6 +463,10 @@ void br_port_state_selection(struct net_bridge *br)
if (p->state != BR_STATE_BLOCKING) if (p->state != BR_STATE_BLOCKING)
br_multicast_enable_port(p); br_multicast_enable_port(p);
/* Multicast is not disabled for the port when it goes in
* blocking state because the timers will expire and stop by
* themselves without sending more queries.
*/
if (p->state == BR_STATE_FORWARDING) if (p->state == BR_STATE_FORWARDING)
++liveports; ++liveports;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment