Commit 9b55669c authored by Markus Elfring's avatar Markus Elfring Committed by David S. Miller

NetCP: Deletion of unnecessary checks before two function calls

The functions cpsw_ale_destroy() and of_dev_put() test whether their argument
is NULL and then return immediately. Thus the test around the call
is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f339664c
...@@ -2011,11 +2011,9 @@ static int gbe_probe(struct netcp_device *netcp_device, struct device *dev, ...@@ -2011,11 +2011,9 @@ static int gbe_probe(struct netcp_device *netcp_device, struct device *dev,
quit: quit:
if (gbe_dev->hw_stats) if (gbe_dev->hw_stats)
devm_kfree(dev, gbe_dev->hw_stats); devm_kfree(dev, gbe_dev->hw_stats);
if (gbe_dev->ale)
cpsw_ale_destroy(gbe_dev->ale); cpsw_ale_destroy(gbe_dev->ale);
if (gbe_dev->ss_regs) if (gbe_dev->ss_regs)
devm_iounmap(dev, gbe_dev->ss_regs); devm_iounmap(dev, gbe_dev->ss_regs);
if (interfaces)
of_node_put(interfaces); of_node_put(interfaces);
devm_kfree(dev, gbe_dev); devm_kfree(dev, gbe_dev);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment