Skip to content

L
linux
Commit 9b9a8067 authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files
Options

scftorture: Add RPC-like IPI tests 

This commit adds the single_weight_rpc module parameter, which causes the
IPI handler to awaken the IPI sender.  In many scheduler configurations,
this will result in an IPI back to the sender that is likely to be
received at a time when the sender CPU is idle.  The intent is to stress
IPI reception during CPU busy-to-idle transitions.
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent af5f6e27
Hide whitespace changes
Inline Side-by-side
Showing with 63 additions and 13 deletions
kernel/scftorture.c
View file @ 9b9a8067
...@@ -64,6 +64,7 @@ torture_param(bool, use_cpus_read_lock, 0, "Use cpus_read_lock() to exclude CPU ...@@ -64,6 +64,7 @@ torture_param(bool, use_cpus_read_lock, 0, "Use cpus_read_lock() to exclude CPU
torture_param(int, verbose, 0, "Enable verbose debugging printk()s"); torture_param(int, verbose, 0, "Enable verbose debugging printk()s");
torture_param(int, weight_resched, -1, "Testing weight for resched_cpu() operations."); torture_param(int, weight_resched, -1, "Testing weight for resched_cpu() operations.");
torture_param(int, weight_single, -1, "Testing weight for single-CPU no-wait operations."); torture_param(int, weight_single, -1, "Testing weight for single-CPU no-wait operations.");
torture_param(int, weight_single_rpc, -1, "Testing weight for single-CPU RPC operations.");
torture_param(int, weight_single_wait, -1, "Testing weight for single-CPU operations."); torture_param(int, weight_single_wait, -1, "Testing weight for single-CPU operations.");
torture_param(int, weight_many, -1, "Testing weight for multi-CPU no-wait operations."); torture_param(int, weight_many, -1, "Testing weight for multi-CPU no-wait operations.");
torture_param(int, weight_many_wait, -1, "Testing weight for multi-CPU operations."); torture_param(int, weight_many_wait, -1, "Testing weight for multi-CPU operations.");
...@@ -86,6 +87,8 @@ struct scf_statistics { ...@@ -86,6 +87,8 @@ struct scf_statistics {
long long n_resched; long long n_resched;
long long n_single; long long n_single;
long long n_single_ofl; long long n_single_ofl;
long long n_single_rpc;
long long n_single_rpc_ofl;
long long n_single_wait; long long n_single_wait;
long long n_single_wait_ofl; long long n_single_wait_ofl;
long long n_many; long long n_many;
...@@ -101,14 +104,17 @@ static DEFINE_PER_CPU(long long, scf_invoked_count); ...@@ -101,14 +104,17 @@ static DEFINE_PER_CPU(long long, scf_invoked_count);
// Data for random primitive selection // Data for random primitive selection
#define SCF_PRIM_RESCHED 0 #define SCF_PRIM_RESCHED 0
#define SCF_PRIM_SINGLE 1 #define SCF_PRIM_SINGLE 1
#define SCF_PRIM_MANY 2 #define SCF_PRIM_SINGLE_RPC 2
#define SCF_PRIM_ALL 3 #define SCF_PRIM_MANY 3
#define SCF_NPRIMS 7 // Need wait and no-wait versions of each, #define SCF_PRIM_ALL 4
// except for SCF_PRIM_RESCHED. #define SCF_NPRIMS 8 // Need wait and no-wait versions of each,
// except for SCF_PRIM_RESCHED and
// SCF_PRIM_SINGLE_RPC.
static char *scf_prim_name[] = { static char *scf_prim_name[] = {
"resched_cpu", "resched_cpu",
"smp_call_function_single", "smp_call_function_single",
"smp_call_function_single_rpc",
"smp_call_function_many", "smp_call_function_many",
"smp_call_function", "smp_call_function",
}; };
...@@ -128,6 +134,8 @@ struct scf_check { ...@@ -128,6 +134,8 @@ struct scf_check {
bool scfc_out; bool scfc_out;
int scfc_cpu; // -1 for not _single(). int scfc_cpu; // -1 for not _single().
bool scfc_wait; bool scfc_wait;
bool scfc_rpc;
struct completion scfc_completion;
}; };
// Use to wait for all threads to start. // Use to wait for all threads to start.
...@@ -158,6 +166,7 @@ static void scf_torture_stats_print(void) ...@@ -158,6 +166,7 @@ static void scf_torture_stats_print(void)
scfs.n_resched += scf_stats_p[i].n_resched; scfs.n_resched += scf_stats_p[i].n_resched;
scfs.n_single += scf_stats_p[i].n_single; scfs.n_single += scf_stats_p[i].n_single;
scfs.n_single_ofl += scf_stats_p[i].n_single_ofl; scfs.n_single_ofl += scf_stats_p[i].n_single_ofl;
scfs.n_single_rpc += scf_stats_p[i].n_single_rpc;
scfs.n_single_wait += scf_stats_p[i].n_single_wait; scfs.n_single_wait += scf_stats_p[i].n_single_wait;
scfs.n_single_wait_ofl += scf_stats_p[i].n_single_wait_ofl; scfs.n_single_wait_ofl += scf_stats_p[i].n_single_wait_ofl;
scfs.n_many += scf_stats_p[i].n_many; scfs.n_many += scf_stats_p[i].n_many;
...@@ -168,9 +177,10 @@ static void scf_torture_stats_print(void) ...@@ -168,9 +177,10 @@ static void scf_torture_stats_print(void)
if (atomic_read(&n_errs) || atomic_read(&n_mb_in_errs) || if (atomic_read(&n_errs) || atomic_read(&n_mb_in_errs) ||
atomic_read(&n_mb_out_errs) || atomic_read(&n_alloc_errs)) atomic_read(&n_mb_out_errs) || atomic_read(&n_alloc_errs))
bangstr = "!!! "; bangstr = "!!! ";
pr_alert("%s %sscf_invoked_count %s: %lld resched: %lld single: %lld/%lld single_ofl: %lld/%lld many: %lld/%lld all: %lld/%lld ", pr_alert("%s %sscf_invoked_count %s: %lld resched: %lld single: %lld/%lld single_ofl: %lld/%lld single_rpc: %lld single_rpc_ofl: %lld many: %lld/%lld all: %lld/%lld ",
SCFTORT_FLAG, bangstr, isdone ? "VER" : "ver", invoked_count, scfs.n_resched, SCFTORT_FLAG, bangstr, isdone ? "VER" : "ver", invoked_count, scfs.n_resched,
scfs.n_single, scfs.n_single_wait, scfs.n_single_ofl, scfs.n_single_wait_ofl, scfs.n_single, scfs.n_single_wait, scfs.n_single_ofl, scfs.n_single_wait_ofl,
scfs.n_single_rpc, scfs.n_single_rpc_ofl,
scfs.n_many, scfs.n_many_wait, scfs.n_all, scfs.n_all_wait); scfs.n_many, scfs.n_many_wait, scfs.n_all, scfs.n_all_wait);
torture_onoff_stats(); torture_onoff_stats();
pr_cont("ste: %d stnmie: %d stnmoe: %d staf: %d\n", atomic_read(&n_errs), pr_cont("ste: %d stnmie: %d stnmoe: %d staf: %d\n", atomic_read(&n_errs),
...@@ -282,10 +292,13 @@ static void scf_handler(void *scfc_in) ...@@ -282,10 +292,13 @@ static void scf_handler(void *scfc_in)
out: out:
if (unlikely(!scfcp)) if (unlikely(!scfcp))
return; return;
if (scfcp->scfc_wait) if (scfcp->scfc_wait) {
WRITE_ONCE(scfcp->scfc_out, true); WRITE_ONCE(scfcp->scfc_out, true);
else if (scfcp->scfc_rpc)
complete(&scfcp->scfc_completion);
} else {
kfree(scfcp); kfree(scfcp);
}
} }
// As above, but check for correct CPU. // As above, but check for correct CPU.
...@@ -319,6 +332,7 @@ static void scftorture_invoke_one(struct scf_statistics *scfp, struct torture_ra ...@@ -319,6 +332,7 @@ static void scftorture_invoke_one(struct scf_statistics *scfp, struct torture_ra
scfcp->scfc_cpu = -1; scfcp->scfc_cpu = -1;
scfcp->scfc_wait = scfsp->scfs_wait; scfcp->scfc_wait = scfsp->scfs_wait;
scfcp->scfc_out = false; scfcp->scfc_out = false;
scfcp->scfc_rpc = false;
} }
} }
switch (scfsp->scfs_prim) { switch (scfsp->scfs_prim) {
...@@ -350,6 +364,34 @@ static void scftorture_invoke_one(struct scf_statistics *scfp, struct torture_ra ...@@ -350,6 +364,34 @@ static void scftorture_invoke_one(struct scf_statistics *scfp, struct torture_ra
scfcp = NULL; scfcp = NULL;
} }
break; break;
case SCF_PRIM_SINGLE_RPC:
if (!scfcp)
break;
cpu = torture_random(trsp) % nr_cpu_ids;
scfp->n_single_rpc++;
scfcp->scfc_cpu = cpu;
scfcp->scfc_wait = true;
init_completion(&scfcp->scfc_completion);
scfcp->scfc_rpc = true;
barrier(); // Prevent race-reduction compiler optimizations.
scfcp->scfc_in = true;
ret = smp_call_function_single(cpu, scf_handler_1, (void *)scfcp, 0);
if (!ret) {
if (use_cpus_read_lock)
cpus_read_unlock();
else
preempt_enable();
wait_for_completion(&scfcp->scfc_completion);
if (use_cpus_read_lock)
cpus_read_lock();
else
preempt_disable();
} else {
scfp->n_single_rpc_ofl++;
kfree(scfcp);
scfcp = NULL;
}
break;
case SCF_PRIM_MANY: case SCF_PRIM_MANY:
if (scfsp->scfs_wait) if (scfsp->scfs_wait)
scfp->n_many_wait++; scfp->n_many_wait++;
...@@ -379,10 +421,12 @@ static void scftorture_invoke_one(struct scf_statistics *scfp, struct torture_ra ...@@ -379,10 +421,12 @@ static void scftorture_invoke_one(struct scf_statistics *scfp, struct torture_ra
} }
if (scfcp && scfsp->scfs_wait) { if (scfcp && scfsp->scfs_wait) {
if (WARN_ON_ONCE((num_online_cpus() > 1 || scfsp->scfs_prim == SCF_PRIM_SINGLE) && if (WARN_ON_ONCE((num_online_cpus() > 1 || scfsp->scfs_prim == SCF_PRIM_SINGLE) &&
!scfcp->scfc_out)) !scfcp->scfc_out)) {
pr_warn("%s: Memory-ordering failure, scfs_prim: %d.\n", __func__, scfsp->scfs_prim);
atomic_inc(&n_mb_out_errs); // Leak rather than trash! atomic_inc(&n_mb_out_errs); // Leak rather than trash!
else } else {
kfree(scfcp); kfree(scfcp);
}
barrier(); // Prevent race-reduction compiler optimizations. barrier(); // Prevent race-reduction compiler optimizations.
} }
if (use_cpus_read_lock) if (use_cpus_read_lock)
...@@ -453,8 +497,8 @@ static void ...@@ -453,8 +497,8 @@ static void
scftorture_print_module_parms(const char *tag) scftorture_print_module_parms(const char *tag)
{ {
pr_alert(SCFTORT_FLAG pr_alert(SCFTORT_FLAG
"--- %s: verbose=%d holdoff=%d longwait=%d nthreads=%d onoff_holdoff=%d onoff_interval=%d shutdown_secs=%d stat_interval=%d stutter=%d use_cpus_read_lock=%d, weight_resched=%d, weight_single=%d, weight_single_wait=%d, weight_many=%d, weight_many_wait=%d, weight_all=%d, weight_all_wait=%d\n", tag, "--- %s: verbose=%d holdoff=%d longwait=%d nthreads=%d onoff_holdoff=%d onoff_interval=%d shutdown_secs=%d stat_interval=%d stutter=%d use_cpus_read_lock=%d, weight_resched=%d, weight_single=%d, weight_single_rpc=%d, weight_single_wait=%d, weight_many=%d, weight_many_wait=%d, weight_all=%d, weight_all_wait=%d\n", tag,
verbose, holdoff, longwait, nthreads, onoff_holdoff, onoff_interval, shutdown, stat_interval, stutter, use_cpus_read_lock, weight_resched, weight_single, weight_single_wait, weight_many, weight_many_wait, weight_all, weight_all_wait); verbose, holdoff, longwait, nthreads, onoff_holdoff, onoff_interval, shutdown, stat_interval, stutter, use_cpus_read_lock, weight_resched, weight_single, weight_single_rpc, weight_single_wait, weight_many, weight_many_wait, weight_all, weight_all_wait);
} }
static void scf_cleanup_handler(void *unused) static void scf_cleanup_handler(void *unused)
...@@ -497,6 +541,7 @@ static int __init scf_torture_init(void) ...@@ -497,6 +541,7 @@ static int __init scf_torture_init(void)
int firsterr = 0; int firsterr = 0;
unsigned long weight_resched1 = weight_resched; unsigned long weight_resched1 = weight_resched;
unsigned long weight_single1 = weight_single; unsigned long weight_single1 = weight_single;
unsigned long weight_single_rpc1 = weight_single_rpc;
unsigned long weight_single_wait1 = weight_single_wait; unsigned long weight_single_wait1 = weight_single_wait;
unsigned long weight_many1 = weight_many; unsigned long weight_many1 = weight_many;
unsigned long weight_many_wait1 = weight_many_wait; unsigned long weight_many_wait1 = weight_many_wait;
...@@ -508,11 +553,13 @@ static int __init scf_torture_init(void) ...@@ -508,11 +553,13 @@ static int __init scf_torture_init(void)
scftorture_print_module_parms("Start of test"); scftorture_print_module_parms("Start of test");
if (weight_resched == -1 && weight_single == -1 && weight_single_wait == -1 && if (weight_resched == -1 &&
weight_single == -1 && weight_single_rpc == -1 && weight_single_wait == -1 &&
weight_many == -1 && weight_many_wait == -1 && weight_many == -1 && weight_many_wait == -1 &&
weight_all == -1 && weight_all_wait == -1) { weight_all == -1 && weight_all_wait == -1) {
weight_resched1 = 2 * nr_cpu_ids; weight_resched1 = 2 * nr_cpu_ids;
weight_single1 = 2 * nr_cpu_ids; weight_single1 = 2 * nr_cpu_ids;
weight_single_rpc1 = 2 * nr_cpu_ids;
weight_single_wait1 = 2 * nr_cpu_ids; weight_single_wait1 = 2 * nr_cpu_ids;
weight_many1 = 2; weight_many1 = 2;
weight_many_wait1 = 2; weight_many_wait1 = 2;
...@@ -523,6 +570,8 @@ static int __init scf_torture_init(void) ...@@ -523,6 +570,8 @@ static int __init scf_torture_init(void)
weight_resched1 = 0; weight_resched1 = 0;
if (weight_single == -1) if (weight_single == -1)
weight_single1 = 0; weight_single1 = 0;
if (weight_single_rpc == -1)
weight_single_rpc1 = 0;
if (weight_single_wait == -1) if (weight_single_wait == -1)
weight_single_wait1 = 0; weight_single_wait1 = 0;
if (weight_many == -1) if (weight_many == -1)
...@@ -534,7 +583,7 @@ static int __init scf_torture_init(void) ...@@ -534,7 +583,7 @@ static int __init scf_torture_init(void)
if (weight_all_wait == -1) if (weight_all_wait == -1)
weight_all_wait1 = 0; weight_all_wait1 = 0;
} }
if (weight_single1 == 0 && weight_single_wait1 == 0 && if (weight_single1 == 0 && weight_single_rpc1 == 0 && weight_single_wait1 == 0 &&
weight_many1 == 0 && weight_many_wait1 == 0 && weight_many1 == 0 && weight_many_wait1 == 0 &&
weight_all1 == 0 && weight_all_wait1 == 0) { weight_all1 == 0 && weight_all_wait1 == 0) {
VERBOSE_SCFTORTOUT_ERRSTRING("all zero weights makes no sense"); VERBOSE_SCFTORTOUT_ERRSTRING("all zero weights makes no sense");
...@@ -546,6 +595,7 @@ static int __init scf_torture_init(void) ...@@ -546,6 +595,7 @@ static int __init scf_torture_init(void)
else if (weight_resched1) else if (weight_resched1)
VERBOSE_SCFTORTOUT_ERRSTRING("built as module, weight_resched ignored"); VERBOSE_SCFTORTOUT_ERRSTRING("built as module, weight_resched ignored");
scf_sel_add(weight_single1, SCF_PRIM_SINGLE, false); scf_sel_add(weight_single1, SCF_PRIM_SINGLE, false);
scf_sel_add(weight_single_rpc1, SCF_PRIM_SINGLE_RPC, true);
scf_sel_add(weight_single_wait1, SCF_PRIM_SINGLE, true); scf_sel_add(weight_single_wait1, SCF_PRIM_SINGLE, true);
scf_sel_add(weight_many1, SCF_PRIM_MANY, false); scf_sel_add(weight_many1, SCF_PRIM_MANY, false);
scf_sel_add(weight_many_wait1, SCF_PRIM_MANY, true); scf_sel_add(weight_many_wait1, SCF_PRIM_MANY, true);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7