Commit 9bfb1839 authored by Ingo Molnar's avatar Ingo Molnar Committed by Linus Torvalds

[PATCH] workqueue: fix schedule_on_each_cpu()

fix the schedule_on_each_cpu() implementation: __queue_work() is now
stricter, hence set the work-pending bit before passing in the new work.

(found in the -rt tree, using Peter Zijlstra's files-lock scalability
patchset)
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 5ccac88e
...@@ -637,9 +637,11 @@ int schedule_on_each_cpu(work_func_t func) ...@@ -637,9 +637,11 @@ int schedule_on_each_cpu(work_func_t func)
mutex_lock(&workqueue_mutex); mutex_lock(&workqueue_mutex);
for_each_online_cpu(cpu) { for_each_online_cpu(cpu) {
INIT_WORK(per_cpu_ptr(works, cpu), func); struct work_struct *work = per_cpu_ptr(works, cpu);
__queue_work(per_cpu_ptr(keventd_wq->cpu_wq, cpu),
per_cpu_ptr(works, cpu)); INIT_WORK(work, func);
set_bit(WORK_STRUCT_PENDING, work_data_bits(work));
__queue_work(per_cpu_ptr(keventd_wq->cpu_wq, cpu), work);
} }
mutex_unlock(&workqueue_mutex); mutex_unlock(&workqueue_mutex);
flush_workqueue(keventd_wq); flush_workqueue(keventd_wq);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment