Commit 9c59a01c authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Stephen Boyd

clk: ti: dra7-atl: Fix reference leak in of_dra7_atl_clk_probe

pm_runtime_get_sync() will increment pm usage counter.
Forgetting to putting operation will result in reference leak.
Add missing pm_runtime_put_sync in some error paths.

Fixes: 9ac33b0c ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220602030838.52057-1-linmq006@gmail.comReviewed-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent d61876a2
...@@ -245,14 +245,16 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev) ...@@ -245,14 +245,16 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)
if (rc) { if (rc) {
pr_err("%s: failed to lookup atl clock %d\n", __func__, pr_err("%s: failed to lookup atl clock %d\n", __func__,
i); i);
return -EINVAL; ret = -EINVAL;
goto pm_put;
} }
clk = of_clk_get_from_provider(&clkspec); clk = of_clk_get_from_provider(&clkspec);
if (IS_ERR(clk)) { if (IS_ERR(clk)) {
pr_err("%s: failed to get atl clock %d from provider\n", pr_err("%s: failed to get atl clock %d from provider\n",
__func__, i); __func__, i);
return PTR_ERR(clk); ret = PTR_ERR(clk);
goto pm_put;
} }
cdesc = to_atl_desc(__clk_get_hw(clk)); cdesc = to_atl_desc(__clk_get_hw(clk));
...@@ -285,8 +287,9 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev) ...@@ -285,8 +287,9 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)
if (cdesc->enabled) if (cdesc->enabled)
atl_clk_enable(__clk_get_hw(clk)); atl_clk_enable(__clk_get_hw(clk));
} }
pm_runtime_put_sync(cinfo->dev);
pm_put:
pm_runtime_put_sync(cinfo->dev);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment