Commit 9c864c23 authored by Ricardo Ribalda Delgado's avatar Ricardo Ribalda Delgado Committed by Felipe Balbi

usb: gadget: udc: net2280: Remove module parameter use_msi

Parameter use_msi was used to enable msi irq on usb338x chips, it was
enabled by default.

There is no reason to prefer non-msi irq on usb338x, and it falls back
to non msi on error.

Therefore remove this option.
Signed-off-by: default avatarRicardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 7a74c481
...@@ -88,11 +88,9 @@ static const char *const ep_name[] = { ...@@ -88,11 +88,9 @@ static const char *const ep_name[] = {
* These two parameters let you use PIO or more aggressive DMA. * These two parameters let you use PIO or more aggressive DMA.
*/ */
static bool use_dma = true; static bool use_dma = true;
static bool use_msi = true;
/* "modprobe net2280 use_dma=n" etc */ /* "modprobe net2280 use_dma=n" etc */
module_param(use_dma, bool, 0444); module_param(use_dma, bool, 0444);
module_param(use_msi, bool, 0444);
/* mode 0 == ep-{a,b,c,d} 1K fifo each /* mode 0 == ep-{a,b,c,d} 1K fifo each
* mode 1 == ep-{a,b} 2K fifo each, ep-{c,d} unavailable * mode 1 == ep-{a,b} 2K fifo each, ep-{c,d} unavailable
...@@ -3426,7 +3424,7 @@ static void net2280_remove(struct pci_dev *pdev) ...@@ -3426,7 +3424,7 @@ static void net2280_remove(struct pci_dev *pdev)
} }
if (dev->got_irq) if (dev->got_irq)
free_irq(pdev->irq, dev); free_irq(pdev->irq, dev);
if (use_msi && dev->quirks & PLX_SUPERSPEED) if (dev->quirks & PLX_SUPERSPEED)
pci_disable_msi(pdev); pci_disable_msi(pdev);
if (dev->regs) if (dev->regs)
iounmap(dev->regs); iounmap(dev->regs);
...@@ -3549,7 +3547,7 @@ static int net2280_probe(struct pci_dev *pdev, const struct pci_device_id *id) ...@@ -3549,7 +3547,7 @@ static int net2280_probe(struct pci_dev *pdev, const struct pci_device_id *id)
goto done; goto done;
} }
if (use_msi && (dev->quirks & PLX_SUPERSPEED)) if (dev->quirks & PLX_SUPERSPEED)
if (pci_enable_msi(pdev)) if (pci_enable_msi(pdev))
ep_err(dev, "Failed to enable MSI mode\n"); ep_err(dev, "Failed to enable MSI mode\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment