Commit 9d8a20a5 authored by Peter Huewe's avatar Peter Huewe Committed by Greg Kroah-Hartman

staging/rtl8192e: Fix compile warning 'is static but declared in .. which is not static'

When compiling this driver I get these compile warnings:

rtllib.h:2573:2: warning: '______f' is static but declared in inline
function 'rtllib_is_empty_essid' which is not static [enabled by
default]
rtllib.h:2579:3: warning: '______f' is static but declared in inline
function 'rtllib_is_empty_essid' which is not static [enabled by
default]
rtllib.h:2594:2: warning: '______f' is static but declared in inline
function 'rtllib_is_valid_mode' which is not static [enabled by default]
rtllib.h:2599:2: warning: '______f' is static but declared in inline
function 'rtllib_is_valid_mode' which is not static [enabled by default]
rtllib.h:2604:2: warning: '______f' is static but declared in inline
function 'rtllib_is_valid_mode' which is not static [enabled by default]
rtllib.h:2618:3: warning: '______f' is static but declared in inline
function 'rtllib_get_hdrlen' which is not static [enabled by default]
rtllib.h:2620:3: warning: '______f' is static but declared in inline
function 'rtllib_get_hdrlen' which is not static [enabled by default]

These functions are declared as extern inline but not 'overloaded'
anywhere so we can declare them static inline and get rid of the
warnings.
Signed-off-by: default avatarPeter Huewe <peterhuewe@gmx.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 53f63dc7
...@@ -2567,7 +2567,7 @@ static inline void *rtllib_priv(struct net_device *dev) ...@@ -2567,7 +2567,7 @@ static inline void *rtllib_priv(struct net_device *dev)
return ((struct rtllib_device *)netdev_priv(dev))->priv; return ((struct rtllib_device *)netdev_priv(dev))->priv;
} }
extern inline int rtllib_is_empty_essid(const char *essid, int essid_len) static inline int rtllib_is_empty_essid(const char *essid, int essid_len)
{ {
/* Single white space is for Linksys APs */ /* Single white space is for Linksys APs */
if (essid_len == 1 && essid[0] == ' ') if (essid_len == 1 && essid[0] == ' ')
...@@ -2583,7 +2583,7 @@ extern inline int rtllib_is_empty_essid(const char *essid, int essid_len) ...@@ -2583,7 +2583,7 @@ extern inline int rtllib_is_empty_essid(const char *essid, int essid_len)
return 1; return 1;
} }
extern inline int rtllib_is_valid_mode(struct rtllib_device *ieee, int mode) static inline int rtllib_is_valid_mode(struct rtllib_device *ieee, int mode)
{ {
/* /*
* It is possible for both access points and our device to support * It is possible for both access points and our device to support
...@@ -2609,7 +2609,7 @@ extern inline int rtllib_is_valid_mode(struct rtllib_device *ieee, int mode) ...@@ -2609,7 +2609,7 @@ extern inline int rtllib_is_valid_mode(struct rtllib_device *ieee, int mode)
return 0; return 0;
} }
extern inline int rtllib_get_hdrlen(u16 fc) static inline int rtllib_get_hdrlen(u16 fc)
{ {
int hdrlen = RTLLIB_3ADDR_LEN; int hdrlen = RTLLIB_3ADDR_LEN;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment