Commit 9df8f4e3 authored by Steve Glendinning's avatar Steve Glendinning Committed by David S. Miller

smsc9420: fix another postfixed timeout

Roel Kluin recently fixed several instances where variables reach -1,
but 0 is tested afterwards.  This patch fixes another, so the timeout
will be correctly detected and a warning printed.
Signed-off-by: default avatarSteve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 494ef10e
...@@ -341,7 +341,7 @@ static int smsc9420_eeprom_send_cmd(struct smsc9420_pdata *pd, u32 op) ...@@ -341,7 +341,7 @@ static int smsc9420_eeprom_send_cmd(struct smsc9420_pdata *pd, u32 op)
do { do {
msleep(1); msleep(1);
e2cmd = smsc9420_reg_read(pd, E2P_CMD); e2cmd = smsc9420_reg_read(pd, E2P_CMD);
} while ((e2cmd & E2P_CMD_EPC_BUSY_) && (timeout--)); } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (--timeout));
if (!timeout) { if (!timeout) {
smsc_info(HW, "TIMED OUT"); smsc_info(HW, "TIMED OUT");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment