Commit 9e02fb96 authored by Michael S. Tsirkin's avatar Michael S. Tsirkin Committed by Avi Kivity

KVM: fix crash on irqfd deassign

irqfd in kvm used flush_work incorrectly: it assumed that work scheduled
previously can't run after flush_work, but since kvm uses a non-reentrant
workqueue (by means of schedule_work) we need flush_work_sync to get that
guarantee.
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reported-by: default avatarJean-Philippe Menil <jean-philippe.menil@univ-nantes.fr>
Tested-by: default avatarJean-Philippe Menil <jean-philippe.menil@univ-nantes.fr>
Signed-off-by: default avatarAvi Kivity <avi@redhat.com>
parent 6221f222
...@@ -90,7 +90,7 @@ irqfd_shutdown(struct work_struct *work) ...@@ -90,7 +90,7 @@ irqfd_shutdown(struct work_struct *work)
* We know no new events will be scheduled at this point, so block * We know no new events will be scheduled at this point, so block
* until all previously outstanding events have completed * until all previously outstanding events have completed
*/ */
flush_work(&irqfd->inject); flush_work_sync(&irqfd->inject);
/* /*
* It is now safe to release the object's resources * It is now safe to release the object's resources
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment