Commit 9e4f0956 authored by Andreas Gruenbacher's avatar Andreas Gruenbacher

gfs2: Reconfiguring frozen filesystem already rejected

Reconfiguring a frozen filesystem is already rejected in
reconfigure_super(), so there is no need to check for that condition
again at the filesystem level.
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
parent e392edd5
...@@ -1590,12 +1590,6 @@ static int gfs2_reconfigure(struct fs_context *fc) ...@@ -1590,12 +1590,6 @@ static int gfs2_reconfigure(struct fs_context *fc)
fc->sb_flags |= SB_RDONLY; fc->sb_flags |= SB_RDONLY;
if ((sb->s_flags ^ fc->sb_flags) & SB_RDONLY) { if ((sb->s_flags ^ fc->sb_flags) & SB_RDONLY) {
struct gfs2_holder freeze_gh;
error = gfs2_freeze_lock_shared(sdp, &freeze_gh, 0);
if (error)
return -EINVAL;
if (fc->sb_flags & SB_RDONLY) { if (fc->sb_flags & SB_RDONLY) {
gfs2_make_fs_ro(sdp); gfs2_make_fs_ro(sdp);
} else { } else {
...@@ -1603,7 +1597,6 @@ static int gfs2_reconfigure(struct fs_context *fc) ...@@ -1603,7 +1597,6 @@ static int gfs2_reconfigure(struct fs_context *fc)
if (error) if (error)
errorfc(fc, "unable to remount read-write"); errorfc(fc, "unable to remount read-write");
} }
gfs2_freeze_unlock(&freeze_gh);
} }
sdp->sd_args = *newargs; sdp->sd_args = *newargs;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment