Commit 9ecdbee8 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by David Sterba

btrfs: move writeback_control::nr_to_write update to __extent_writepage

Move the nr_to_write accounting from __extent_writepage_io to
__extent_writepage_io as we'll grow another __extent_writepage_io that
doesn't want this accounting soon.  Also drop the obsolete comment -
decrementing a counter in the on-stack writeback_control data structure
doesn't need the page lock.
Reviewed-by: default avatarAnand Jain <anand.jain@oracle.com>
Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent f22b5dcb
...@@ -1370,12 +1370,6 @@ static noinline_for_stack int __extent_writepage_io(struct btrfs_inode *inode, ...@@ -1370,12 +1370,6 @@ static noinline_for_stack int __extent_writepage_io(struct btrfs_inode *inode,
return 1; return 1;
} }
/*
* we don't want to touch the inode after unlocking the page,
* so we update the mapping writeback index now
*/
bio_ctrl->wbc->nr_to_write--;
bio_ctrl->end_io_func = end_bio_extent_writepage; bio_ctrl->end_io_func = end_bio_extent_writepage;
while (cur <= end) { while (cur <= end) {
u64 disk_bytenr; u64 disk_bytenr;
...@@ -1521,6 +1515,8 @@ static int __extent_writepage(struct page *page, struct btrfs_bio_ctrl *bio_ctrl ...@@ -1521,6 +1515,8 @@ static int __extent_writepage(struct page *page, struct btrfs_bio_ctrl *bio_ctrl
if (ret == 1) if (ret == 1)
return 0; return 0;
bio_ctrl->wbc->nr_to_write--;
done: done:
if (nr == 0) { if (nr == 0) {
/* make sure the mapping tag for page dirty gets cleared */ /* make sure the mapping tag for page dirty gets cleared */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment