Commit 9f19fa62 authored by Julia Lawall's avatar Julia Lawall Committed by John W. Linville

drivers/net/wireless/wl12xx: Use available error codes

In each case, error codes are stored in ret, but the return value is always
0.  Return ret instead.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
local idexpression x;
constant C;
@@

if (...) { ...
  x = -C
  ... when != x
(
  return <+...x...+>;
|
  return NULL;
|
  return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Acked-by: default avatarKalle Valo <kvalo@adurom.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 30bf4169
...@@ -380,7 +380,7 @@ int wl1251_acx_pd_threshold(struct wl1251 *wl) ...@@ -380,7 +380,7 @@ int wl1251_acx_pd_threshold(struct wl1251 *wl)
out: out:
kfree(pd); kfree(pd);
return 0; return ret;
} }
int wl1251_acx_slot(struct wl1251 *wl, enum acx_slot_type slot_time) int wl1251_acx_slot(struct wl1251 *wl, enum acx_slot_type slot_time)
......
...@@ -200,7 +200,7 @@ int wl1251_cmd_vbm(struct wl1251 *wl, u8 identity, ...@@ -200,7 +200,7 @@ int wl1251_cmd_vbm(struct wl1251 *wl, u8 identity,
out: out:
kfree(vbm); kfree(vbm);
return 0; return ret;
} }
int wl1251_cmd_data_path(struct wl1251 *wl, u8 channel, bool enable) int wl1251_cmd_data_path(struct wl1251 *wl, u8 channel, bool enable)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment