Commit 9f65df9c authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Takashi Iwai

ALSA: firewire-tascam: Fix integer overflow in midi_port_work()

As snd_fw_async_midi_port.consume_bytes is unsigned int, and
NSEC_PER_SEC is 1000000000L, the second multiplication in

    port->consume_bytes * 8 * NSEC_PER_SEC / 31250

always overflows on 32-bit platforms, truncating the result.  Fix this
by precalculating "NSEC_PER_SEC / 31250", which is an integer constant.

Note that this assumes port->consume_bytes <= 16777.

Fixes: 531f4718 ("ALSA: firewire-lib/firewire-tascam: localize async midi port")
Reviewed-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20210111130251.361335-3-geert+renesas@glider.beSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e7c22eea
...@@ -209,7 +209,7 @@ static void midi_port_work(struct work_struct *work) ...@@ -209,7 +209,7 @@ static void midi_port_work(struct work_struct *work)
/* Set interval to next transaction. */ /* Set interval to next transaction. */
port->next_ktime = ktime_add_ns(ktime_get(), port->next_ktime = ktime_add_ns(ktime_get(),
port->consume_bytes * 8 * NSEC_PER_SEC / 31250); port->consume_bytes * 8 * (NSEC_PER_SEC / 31250));
/* Start this transaction. */ /* Start this transaction. */
port->idling = false; port->idling = false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment