Commit 9f75c8e1 authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Simon Wunderlich

batman-adv: Disallow mcast src address for data frames

The routing checks are validating the source mac address of the outer
ethernet header. They reject every source mac address which is a broadcast
address. But they also have to reject any multicast mac addresses.
Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
[sw@simonwunderlich.de: fix commit message typo]
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent 7d72d174
...@@ -368,8 +368,8 @@ int batadv_recv_icmp_packet(struct sk_buff *skb, ...@@ -368,8 +368,8 @@ int batadv_recv_icmp_packet(struct sk_buff *skb,
if (is_broadcast_ether_addr(ethhdr->h_dest)) if (is_broadcast_ether_addr(ethhdr->h_dest))
goto free_skb; goto free_skb;
/* packet with broadcast sender address */ /* packet with broadcast/multicast sender address */
if (is_broadcast_ether_addr(ethhdr->h_source)) if (is_multicast_ether_addr(ethhdr->h_source))
goto free_skb; goto free_skb;
/* not for me */ /* not for me */
...@@ -466,8 +466,8 @@ static int batadv_check_unicast_packet(struct batadv_priv *bat_priv, ...@@ -466,8 +466,8 @@ static int batadv_check_unicast_packet(struct batadv_priv *bat_priv,
if (is_broadcast_ether_addr(ethhdr->h_dest)) if (is_broadcast_ether_addr(ethhdr->h_dest))
return -EBADR; return -EBADR;
/* packet with broadcast sender address */ /* packet with broadcast/multicast sender address */
if (is_broadcast_ether_addr(ethhdr->h_source)) if (is_multicast_ether_addr(ethhdr->h_source))
return -EBADR; return -EBADR;
/* not for me */ /* not for me */
...@@ -1159,8 +1159,8 @@ int batadv_recv_bcast_packet(struct sk_buff *skb, ...@@ -1159,8 +1159,8 @@ int batadv_recv_bcast_packet(struct sk_buff *skb,
if (!is_broadcast_ether_addr(ethhdr->h_dest)) if (!is_broadcast_ether_addr(ethhdr->h_dest))
goto free_skb; goto free_skb;
/* packet with broadcast sender address */ /* packet with broadcast/multicast sender address */
if (is_broadcast_ether_addr(ethhdr->h_source)) if (is_multicast_ether_addr(ethhdr->h_source))
goto free_skb; goto free_skb;
/* ignore broadcasts sent by myself */ /* ignore broadcasts sent by myself */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment